Skip to content

Commit 6113e89

Browse files
committedJul 2, 2015
Use os.Unsetenv in options_test
Signed-off-by: Ahmet Alp Balkan <[email protected]>
1 parent 930fefc commit 6113e89

File tree

1 file changed

+20
-11
lines changed

1 file changed

+20
-11
lines changed
 

‎cluster/options_test.go

+20-11
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ import (
1111
var opts = DriverOpts{"foo1=bar", "foo2=-5", "foo3=7", "foo4=0.6", "foo5=127.0.0.1"}
1212

1313
func TestString(t *testing.T) {
14-
os.Setenv("FOO_4", "bar")
15-
// FIXME: Use Unsetenv when switching to go 1.4
16-
defer os.Setenv("FOO_4", "")
14+
if err := os.Setenv("FOO_4", "bar"); err != nil {
15+
t.Fatal(err)
16+
}
17+
defer os.Unsetenv("FOO_4")
1718

1819
val, ok := opts.String("foo1", "")
1920
assert.True(t, ok)
@@ -41,8 +42,10 @@ func TestString(t *testing.T) {
4142
}
4243

4344
func TestInt(t *testing.T) {
44-
os.Setenv("FOO_4", "bar")
45-
defer os.Setenv("FOO_4", "")
45+
if err := os.Setenv("FOO_4", "bar"); err != nil {
46+
t.Fatal(err)
47+
}
48+
defer os.Unsetenv("FOO_4")
4649

4750
val, ok := opts.Int("foo1", "")
4851
assert.True(t, ok)
@@ -70,8 +73,10 @@ func TestInt(t *testing.T) {
7073
}
7174

7275
func TestUint(t *testing.T) {
73-
os.Setenv("FOO_4", "bar")
74-
defer os.Setenv("FOO_4", "")
76+
if err := os.Setenv("FOO_4", "bar"); err != nil {
77+
t.Fatal(err)
78+
}
79+
defer os.Unsetenv("FOO_4")
7580

7681
val, ok := opts.Uint("foo1", "")
7782
assert.True(t, ok)
@@ -99,8 +104,10 @@ func TestUint(t *testing.T) {
99104
}
100105

101106
func TestFloat(t *testing.T) {
102-
os.Setenv("FOO_4", "0.2")
103-
defer os.Setenv("FOO_4", "")
107+
if err := os.Setenv("FOO_4", "0.2"); err != nil {
108+
t.Fatal(err)
109+
}
110+
defer os.Unsetenv("FOO_4")
104111

105112
val, ok := opts.Float("foo1", "")
106113
assert.True(t, ok)
@@ -128,8 +135,10 @@ func TestFloat(t *testing.T) {
128135
}
129136

130137
func TestIP(t *testing.T) {
131-
os.Setenv("FOO_4", "0.0.0.0")
132-
defer os.Setenv("FOO_4", "")
138+
if err := os.Setenv("FOO_4", "0.0.0.0"); err != nil {
139+
t.Fatal(err)
140+
}
141+
defer os.Unsetenv("FOO_4")
133142

134143
val, ok := opts.IP("foo5", "")
135144
assert.True(t, ok)

0 commit comments

Comments
 (0)