Rewrote ScreenEditMenu in lua to give it a better layout and usability.

Removed old ScreenEditMenu and EditMenu translation strings.
Removed old ScreenEditMenu and EditMenu metrics.
Added LongStepsType translation section for including the game type.
Added foreach_ordered to 00 init.lua because it was removed when ThemePrefs was removed.
Added on_focus and on_unfocus functions to nesty menu items.
Added page_down and page_up functions to nesty menu navigation.
Added a way to set the back element text for a submenu.
Changed AutoKeysounds to print an error message when it can't load the music because no steps are set.
Fixed bugs in GameState:SetStepsForEditMode lua function.
Changed NotesLoaderSM and SSC to treat a blank difficulty string as Edit.
Changed RollingNumbers to print an error if the target number is not finite.
Added prompt_screen lua function for activating ScreenPrompt from lua with a function to call after the prompt.
Updated changelog.

Author: kyzentun

Docs/Changelog_sm5_1.txt

@@ -7,6 +7,13 @@ StepMania 5.1 and StepMania 5.0 have separate changelogs so that devs working
 on the different branches don't have conflicts on the changelog file.
 ________________________________________________________________________________
 
+2016/07/25
+----------
+* [ScreenEditMenu] Complete rewrite removes the old ScreenEditMenu and
+  EditMenu classes with their metrics and language strings.  See
+  Docs/Themerdocs/5.1_incompatibilities/ScreenEditMenu_rewrite.md for details.
+  [kyzentun]
+
 2016/07/18
 ----------
 * [Player] Removed HoldJudgment class.  Hold judgments should be displayed by

Docs/Themerdocs/5.1_incompatibilities/ScreenEditMenu_rewrite.md

@@ -0,0 +1,16 @@
+## Removed metrics:
+Everything in the ScreenEditMenu section.
+
+Everything in the EditMenu section.
+
+## Removed language entries:
+Everything in the EditMenuAction section.
+Everything in the EditMenu section.
+Everything in the EditMenuRow section.
+Everything in the ScreenEditMenu section.
+
+## New language entries:
+See ScreenEditMenu section in _fallback.
+
+
+## bug Kyzentun to finish this explanation

Themes/_fallback/Languages/en.ini

@@ -92,29 +92,6 @@ Survival=Survival
 You must type a program directory before clicking Add.=You must type a program directory before clicking Add.
 '%s' is not a valid installation directory.='%s' is not a valid installation directory.
 
-[EditMenuAction]
-Create=Create New
-Delete=Delete Existing
-Edit=Edit Existing
-Practice=Practice
-LoadAutosave=Load Autosave
-
-[EditMenu]
-Blank=Blank
-No Group Selected.=No Group Selected.
-No StepsType selected.=No StepsType selected.
-No Steps selected.=No Steps selected.
-No valid action.=No valid action.
-
-[EditMenuRow]
-Action=Action
-Group=Group
-Song=Song
-SourceSteps=Fill Steps
-SourceStepsType=Fill Type
-Steps=Steps
-StepsType=Type
-
 [GameButton]
 Back=Back
 Down=Down
@@ -1830,25 +1807,32 @@ New Sound=New Sound
 Enter New Keysound File=Enter the name of the new keysound file.\nPlease make sure it is spelt right.
 
 [ScreenEditMenu]
-HeaderText=Edit Song/Steps
-HeaderSubText=Make your songs perfect
-Continue with delete?=Continue with delete?
-Enter a description for this edit.=Enter a description for this edit.
-ExplanationAction=Choose the action to perform using the values selected above.
-ExplanationGroup=Choose the group of songs you want to select from.
-ExplanationSong=Choose which song you want to edit.
-ExplanationSteps=Choose the steps you want to edit.\nSelect "New Edit" to create a new edit file.
-ExplanationStepsType=Choose the type of steps that you want to edit.
-ExplanationSourceSteps=Choose the steps you want to fill into a new edit.
-ExplanationSourceStepsType=Choose the type of steps that you want to use fill into a new edit.\nChoose "Blank" to create a new edit with no initial steps.
-One of the selected things is invalid.  Pick something valid instead.=One of the selected things is invalid.  Pick something valid instead.
-Profile name cannot be blank.=Profile name can not be blank.
-The name you chose conflicts with another profile. Please use a different name.=The name you chose conflicts with another profile.  Please use a different name.
-These steps are produced by autogen.  You do not need to delete them.=These steps are produced by autogen.  You do not need to delete them.
-These steps will be lost permanently.=These steps will be lost permanently.
-This song is missing a music file and cannot be edited.=This song is missing a music file and can not be edited.
-The song directory is read-only and cannot be edited.=The song directory is read-only and cannot be edited.
-Blank=Blank
+edit_description_prompt=Enter a description for this edit.
+delete_chart_prompt=Are you sure you want to delete this chart?
+
+steps_action_back=Back to steps
+copy_dest_slot_back=Back to pick style
+copy_dest_style_back=Back to pick chart to copy
+copy_from_back=Back to pick chart to edit
+new_chart_slot_back=Back to pick stepstype
+new_chart_stype_back=Back to pick chart to edit
+steps_list_back=Back to pick song
+song_list_back=Back to pick group
+exit_edit_menu=Exit edit menu
+
+edit_chart=Edit chart
+delete_chart=Delete chart
+new_chart=New chart
+copy_from=New copy of chart
+
+copy_to_slot_format=Copy to %s %s
+new_chart_slot_format=New %s %s
+
+copy_dest_slot_menu=Pick difficulty for new chart
+copy_dest_stype_menu=Pick stepstype for new chart
+copy_from_menu=Pick chart to copy from
+new_chart_slot_menu=Pick difficulty for new chart
+new_chart_stype_menu=Pick stepstype for new chart
 
 [ScreenPracticeMenu]
 HeaderText=Practice Songs
@@ -2372,6 +2356,47 @@ Kickbox_Quadarm=Quadarm
 Kickbox_Insect=Insect
 Kickbox_Arachnid=Arachnid
 
+[LongStepsType]
+Dance_Single=Dance Single
+Dance_Double=Dance Double
+Dance_Couple=Dance Couple
+Dance_Solo=Dance Solo
+Dance_Routine=Dance Routine
+Dance_Threepanel=Dance 3 Panels
+Pump_Single=Pump Single
+Pump_Double=Pump Double
+Pump_Halfdouble=Pump Half-Double
+Pump_Couple=Pump Couple
+Pump_Routine=Pump Routine
+Kb7_Single=KB7
+Ez2_Single=Ez2 Single
+Ez2_Double=Ez2 Double
+Ez2_Real=Ez2 Real
+Para_Single=Para Single
+Ds3ddx_Single=DS3DDX Single
+Bm_Single5=BM 5 Keys
+Bm_Double5=BM 10 Keys
+Bm_Single7=BM 7 Keys
+Bm_Double7=BM 14 Keys
+Maniax_Single=Maniax Single
+Maniax_Double=Maniax Double
+Techno_Single4=Techno Single 4
+Techno_Single5=Techno Single 5
+Techno_Single8=Techno Single 8
+Techno_Double4=Techno Double 4
+Techno_Double5=Techno Double 5
+Techno_Double8=Techno Double 8
+Pnm_Five=PNM 5 Button
+Pnm_Nine=PNM 9 Button
+Guitar_Five=Guitar 5 Frets
+Karaoke=Karaoke
+Lights_Cabinet=Lights
+Kickbox_Human=Kickbox Human
+Kickbox_Quadarm=Kickbox Quadarm
+Kickbox_Insect=Kickbox Insect
+Kickbox_Arachnid=Kickbox Arachnid
+
+
 [StyleType]
 StyleType_OnePlayerOneSide=1 Player
 StyleType_TwoPlayersTwoSides=2 Players - Versus

Themes/_fallback/Scripts/00 init.lua

@@ -54,6 +54,28 @@ function join(delimiter, list)
 	return table.concat(list, delimiter)
 end
 
+function foreach_by_sorted_keys(tbl, keys, func)
+	table.sort(keys)
+	for _, key in ipairs(keys) do func(key, tbl[key]) end
+end
+
+function foreach_ordered( tbl, func )
+	local string_keys= {}
+	local number_keys= {}
+	-- First person to to use this on a table that uses something else as keys
+	-- gets to extend this function to cover more types.  And a beating. -Kyz
+	for k,_ in pairs(tbl) do
+		if type(k) == "string" then
+			table.insert(string_keys, k)
+		elseif type(k) == "number" then
+			table.insert(number_keys, k)
+		end
+	end
+	-- iterate in sorted order
+	foreach_by_sorted_keys(tbl, number_keys, func)
+	foreach_by_sorted_keys(tbl, string_keys, func)
+end
+
 -- (c) 2006 Glenn Maynard
 -- All rights reserved.
 --

Themes/_fallback/Scripts/04 nested_options_menu.lua

@@ -131,7 +131,7 @@ nesty_cursor_mt= {
 				LoadActor(THEME:GetPathG(params.parts_name, "Right")) ..
 				{InitCommand= function(subself) self.right= subself end},
 			}
-			return frame;
+			return frame
 		end,
 		refit= function(self, nx, ny, nw, nh)
 			nx= nx or self.container:GetX()
@@ -408,8 +408,18 @@ local value_item_mt= {
 		get_cursor_fit= function(self)
 			return {0, 0, self.width + 4, self.height + 4}
 		end,
-		gain_focus= play_gain_focus,
-		lose_focus= play_lose_focus,
+		gain_focus= function(self)
+			play_gain_focus(self)
+			if self.info and type(self.info.on_focus) == "function" then
+				self.info.on_focus()
+			end
+		end,
+		lose_focus= function(self)
+			play_lose_focus(self)
+			if self.info and type(self.info.on_unfocus) == "function" then
+				self.info.on_unfocus()
+			end
+		end,
 }}
 
 nesty_items= {
@@ -615,6 +625,30 @@ local general_menu_mt= {
 					self:get_cursor_element():gain_focus()
 					return true, false, "move_down"
 				end,
+				page_down= function(self)
+					if self.cursor_pos < #self.info_set then
+						unfocus_cursor(self)
+						self.cursor_pos= self.cursor_pos + self.display.scroller.num_items
+						if self.cursor_pos > #self.info_set then
+							self.cursor_pos= #self.info_set
+						end
+						self.display:scroll(self.cursor_pos)
+						self:get_cursor_element():gain_focus()
+					end
+					return true, false, "move_down"
+				end,
+				page_up= function(self)
+					if self.cursor_pos > 1 then
+						unfocus_cursor(self)
+						self.cursor_pos= self.cursor_pos - self.display.scroller.num_items
+						if self.cursor_pos < 1 then
+							self.cursor_pos= 1
+						end
+						self.display:scroll(self.cursor_pos)
+						self:get_cursor_element():gain_focus()
+					end
+					return true, false, "move_up"
+				end,
 				Start= function(self)
 					if self.info_set[self.cursor_pos].text == nesty_menu_up_element.text then
 						-- This position is the "up" element that moves the
@@ -694,6 +728,7 @@ nesty_option_menus.menu= {
 			else
 				self.menu_data= self.init_args
 			end
+			self.up_text= self.menu_data.up_text or self.up_text
 			self:insert_up(self.menu_data)
 			self.name= self.menu_data.name or ""
 			self.recall_init_on_pop= self.menu_data.recall_init_on_pop
@@ -753,6 +788,8 @@ nesty_option_menus.menu= {
 					end
 					self.info_set[disp_slot].translatable= data.translatable
 					self.info_set[disp_slot].translatable_value= data.translatable_value
+					self.info_set[disp_slot].on_focus= data.on_focus
+					self.info_set[disp_slot].on_unfocus= data.on_unfocus
 					if data.args and type(data.args) == "table" then
 						data.args.name= data.name
 					end