Freeze when passing certain characters to jaconv.kana2alphabet

[nicoyou]

Nice to get started.
Thank you for providing a great library.
In ver.0.3, when I pass "えっっ" to a function as follows, the function freezes.
jaconv.kana2alphabet("えっっ")

[frog42]

どうやって訳すでしょうか？
"E,e,e"?
"Eee"?

[nicoyou]

The small "つ" can be expressed with "ltu".
example:
"Eltultu"

[frog42]

That's how you would input it on a keyboard, but it's not really an accurate romaji representation.

[frog42]

でも仕方ないかな？
「ぜんっっっぜん」は"zenzzzzen"になったら分かるけど
「っ」の後は何もない場合、実は日本語じゃないじゃない？
勿論エラーが出ない方がいいけどカタカナに変えた言葉そのままひらがなに戻せないとおかしいね。
"ltu"を「っ」に変えると問題になる可能性あるかな？

[nicoyou]

I see.
I understand why it is difficult to convert, but it is a fatal problem when a program using this library becomes unresponsive when it enters an infinite loop in the library.
I think it needs to either raise an exception or leave the "っ" as it is without conversion, etc.

[nicoyou]

I couldn't think of any particular problem caused by converting "ltu" to "っ".

[frog42]

I found the problem and submitted a pull request that should fix it. The program currently changes 「えっ」 to "extsu", so for your stated error with 「えっっ」I made it so the program would convert to "extsuxtsu". This should also fix any issues such as 「えっっっ」, etc.

Ultimately, the code would be safer using a FOR loop instead of a WHILE loop, but I wanted to make as few changes as possible and I couldn't think of any other case where this might create an infinite loop.

Hopefully @ikegami-yukino can accept the changes for us.

[nicoyou]

Thank you.
I think this is a good change.

[ikegami-yukino]

@nicoyou @frog42
I uploaded the bug-fix version to PyPI.
Thanks a lot!

$ pip install jaconv