Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official WordPress plugin #114

Open
imsky opened this issue Oct 9, 2014 · 4 comments
Open

Official WordPress plugin #114

imsky opened this issue Oct 9, 2014 · 4 comments

Comments

@imsky
Copy link
Owner

imsky commented Oct 9, 2014

No description provided.

@imsky imsky added 2.7 and removed 2.7 labels Nov 17, 2014
@Rarst
Copy link
Contributor

Rarst commented Mar 8, 2015

While I pulled it from official WP repo (because reasons), my plugin is still available — https://github.com/Rarst/holder-wp

Might be a little dusty, I should perform a refresh pass. :)

@imsky
Copy link
Owner Author

imsky commented Mar 9, 2015

I think the plugin should be as pass-through as possible, which is what motivated this issue.

The current holder-wp syntax of [holder height="50" width="100" text="thumbnail"] is less compact than the official syntax, e.g. [holder src="100x50/text:thumbnail"], and would require more support.

Let me know if you update holder-wp, I'll definitely take a look.

@Rarst
Copy link
Contributor

Rarst commented Mar 9, 2015

That wouldn't be hard to implement, open issue with spec to follow in plugin's repo?

Although I would say "compact" variant is semantically uncommon in WP shortcodes. They are often horribly verbose.

@imsky
Copy link
Owner Author

imsky commented Mar 10, 2015

All right, I'll open the issue. Regarding WP shortcodes, I'd rather have one way of doing things - custom tags for Holder images is already a stretch, since it makes things like custom themes harder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants