Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove background-color #16

Closed
mdo opened this issue Nov 30, 2012 · 1 comment
Closed

Remove background-color #16

mdo opened this issue Nov 30, 2012 · 1 comment

Comments

@mdo
Copy link

mdo commented Nov 30, 2012

While implementing Holder, I realized that it overrides any background-color set in my CSS. Here's a screenshot and the relevant CSS:

.img-polaroid {
  padding: 4px;
  background-color: #fff;
  border: 1px solid #ccc;
}

When used on a Holder image, the background-color is overwritten by the default theme. If I remove #L79, the problem is resolved and my CSS remains intact (note the white borders here given the padding and background I set in CSS).

Any reason the <img> gets a background color in addition to the image?

@imsky imsky closed this as completed in 2871be7 Nov 30, 2012
@imsky
Copy link
Owner

imsky commented Nov 30, 2012

The reason background color is set is so that Holder can gracefully degrade on clients that don't support <canvas> (IE6, Android 2.*). It's possible that it'll also be used in the future as another way to implement fluid placeholders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants