Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skorecard() class is slow #74

Closed
orchardbirds opened this issue Nov 22, 2021 · 2 comments
Closed

Skorecard() class is slow #74

orchardbirds opened this issue Nov 22, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@orchardbirds
Copy link
Contributor

From the benchmarks notebook, Skorecard is now 'very' slow:

Screenshot 2021-11-22 at 13 07 15

@orchardbirds orchardbirds added enhancement New feature or request good first issue Good for newcomers labels Nov 22, 2021
@dlaprins
Copy link

dlaprins commented Jun 3, 2022

It seems to me that part of the reason for the speed issue is that the fit of the BucketingProcess class calculates bucket_tables and summaries both in the call to the fit of the underlying (pre-)bucketers, and in the BucketingProcess fit itself.

I have added a get_statistics Boolean to the bucketers which can be used to turn off the calculation of the bucket tables and summary in the bucketers. Making use of this feature in a BucketingProcess results in no loss of functionality, but does result in a minor speed increase. A notebook benchmark_stats_feature in docs/discussion compares running Skorecard with and without the bucketer statistics.

@timvink
Copy link
Contributor

timvink commented Jun 8, 2022

Thanks @dlaprins .

We could probably optimize the speed further, let's do that in separate issues should the need arise.

@timvink timvink closed this as completed Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants