Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify Solr about slug changes #13

Open
dmnkhhn opened this issue Jul 1, 2020 · 2 comments
Open

Notify Solr about slug changes #13

dmnkhhn opened this issue Jul 1, 2020 · 2 comments

Comments

@dmnkhhn
Copy link

dmnkhhn commented Jul 1, 2020

Hello there,

we have a problem with EXT:ig_slug and the Solr extension.
Manually updating a slug marks the page as changed so that the indexer can update it's information about this very page.
Updating slugs with this extension seem to bypass this and the indexer won't pick up the new slugs which leads to 404 errors in the search results.
Can you please add a function that notifies the Solr extension about the changed slugs? Thanks :-)

@akiessling
Copy link

I guess it should be enough to change \Ig\IgSlug\Utility\SlugUtility::updateEntry to use the DataHandler for updating the slug so that the record monitor from solr can pick up the change with the datahandler hook.
Is there a reason why

public function updateEntry(array $entry): void
uses the querybuilder?

@akiessling
Copy link

An additional sidenote: using the the DataHandler is of course more expensive compared to the querybuilder since it involves access checks, logging etc. So for populating a "fresh table" with hundreds or thousands of records this might need a paging or limit like proposed in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants