Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for docker compose cli #614

Open
andytson-inviqa opened this issue Jul 14, 2021 · 4 comments
Open

Add support for docker compose cli #614

andytson-inviqa opened this issue Jul 14, 2021 · 4 comments

Comments

@andytson-inviqa
Copy link
Contributor

docker compose cli will be replacing docker-compose at some point. Docker Desktop already includes it under docker compose and has a plan to migrate docker-compose over to it, starting with an experimental feature that makes docker-compose call docker compose

Trying it out I found some initial issues with ws external-images config but there may be more issues

@kierenevans
Copy link
Contributor

kierenevans commented Sep 1, 2021

From docker compose config:

# ...
  relay:
    build:
      context: /Users/kevans/Sites/example/.my127ws/docker/image/relay
      dockerfile: /Users/kevans/Sites/example/.my127ws/docker/image/relay/Dockerfile
docker compose version
Docker Compose version v2.0.0-rc.2

This bubbles up to errors with ws external-images pull

Raised https://github.com/docker/compose-cli/issues/2063 for the difference, but might be intentional

@kierenevans
Copy link
Contributor

Lots of complaints about:

WARN[0000] network shared: network.external.name is deprecated in favor of network.name

@kierenevans
Copy link
Contributor

kierenevans commented Sep 1, 2021

Formatting of the welcome message when run via docker-compose exec -T has lots of spaces:

➜  tmp-test git:(614-fix-dockerfile-path-with-compose-cli-v2) ✗ docker-compose exec -T -u build console app init
WARN[0000] network shared: network.external.name is deprecated in favor of network.name
find: '/app/tools/assets/development/': No such file or directory

                                                                 Welcome!
                                                                         --------
                                                                                 https://ci-php-sample-dynamic.my127.site
                                                                                                                         Admin: /admin
                                                                                                                                        Username: admin
                                                                                                                                                         Password: admin123

               %
➜  tmp-test git:(614-fix-dockerfile-path-with-compose-cli-v2) ✗ docker-compose exec -u build console app init
WARN[0000] network shared: network.external.name is deprecated in favor of network.name
find: '/app/tools/assets/development/': No such file or directory

Welcome!
--------
https://ci-php-sample-dynamic.my127.site
Admin: /admin
  Username: admin
  Password: admin123

Seems to be https://github.com/docker/compose-cli/issues/2008#issuecomment-909413300

@andytson-inviqa
Copy link
Contributor Author

andytson-inviqa commented Mar 30, 2023

#761 new compose bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants