Skip to content

Commit e65a2b2

Browse files
GEODE-8469: fix windows test failure (apache#5542)
* fix commit message in bump script * fix for windows
1 parent 86c32e4 commit e65a2b2

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

dev-tools/dependencies/bump.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,15 @@ fi
4343
NAME="$1"
4444
SRCH="$2"
4545
REPL="$3"
46+
OLDV="$SRCH"
4647
SRCH=${SRCH//./\\.}
4748
git grep -n --color "$SRCH" | cat
4849
git grep -l "$SRCH" | while read f; do
4950
sed -e "s/$SRCH/$REPL/g" -i.bak $f || true
5051
rm -f $f.bak
5152
done
5253
git add -p
53-
git commit -m "Bump $NAME from $OLDV to $NEWV"
54+
git commit -m "Bump $NAME from $OLDV to $REPL"
5455
if [ $(git diff | wc -l) -gt 0 ] ; then
5556
git stash
5657
git stash drop

geode-junit/src/test/java/org/apache/geode/test/junit/rules/ExpectedTimeoutRuleTest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,9 @@ public void failsWithExpectedTimeoutButWrongError() {
8282
assertThat(failures.size()).as("Failures: " + failures).isEqualTo(1);
8383

8484
Failure failure = failures.get(0);
85-
String expectedMessage = "\n"
85+
String expectedMessage = System.lineSeparator()
8686
+ "Expected: (an instance of java.util.concurrent.TimeoutException and exception with message a string containing \"this is a message for FailsWithExpectedTimeoutButWrongError\")"
87-
+ "\n" + " "
87+
+ System.lineSeparator() + " "
8888
+ "but: an instance of java.util.concurrent.TimeoutException <java.lang.NullPointerException> is a java.lang.NullPointerException";
8989
assertThat(failure.getException()).isExactlyInstanceOf(AssertionError.class)
9090
.hasMessageContaining(expectedMessage);

0 commit comments

Comments
 (0)