Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travic CI successed when nyc throw error #1400

Open
Val-istar-Guo opened this issue Apr 4, 2021 · 2 comments
Open

Travic CI successed when nyc throw error #1400

Val-istar-Guo opened this issue Apr 4, 2021 · 2 comments

Comments

@Val-istar-Guo
Copy link

image

Link to bug demonstration repository

keq-proxy repository
The ci job

Expected Behavior

CI should build fail and exited with error.

Observed Behavior

The npc had throw error: ERROR: Coverage for branches (50%) does not meet global threshold (60%).
But Travis CI build success and exited with code 0.

Troubleshooting steps

emmm...Run it in Travis CI?

I'm not sure if it is Travis CI's problem or NYC's problem. Or my configuration is wrong. Hope someone can help me.

@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 16, 2022
@Val-istar-Guo
Copy link
Author

oh my god

@stale stale bot removed the stale label Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant