From bcd51ec0341fdb91cba213dbc1f9bab33716c9d6 Mon Sep 17 00:00:00 2001 From: Viraj Kulkarni Date: Wed, 29 Jan 2025 16:42:49 -0800 Subject: [PATCH] fixing rebase --- admiral/pkg/clusters/admiralDatabaseClient.go | 21 ++----------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/admiral/pkg/clusters/admiralDatabaseClient.go b/admiral/pkg/clusters/admiralDatabaseClient.go index 680a4fd1..3f9b5062 100644 --- a/admiral/pkg/clusters/admiralDatabaseClient.go +++ b/admiral/pkg/clusters/admiralDatabaseClient.go @@ -101,11 +101,11 @@ func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Get(env, identit func checkIfDynamicConfigDatabaseClientIsInitialize(dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) error { if dynamicConfigDatabaseClient == nil || dynamicConfigDatabaseClient.dynamoClient == nil { - return fmt.Errorf("DynamicConfig: dynamoClient is not initialized") + return fmt.Errorf("task=%s, dynamoClient is not initialized", common.DynamicConfigUpdate) } if dynamicConfigDatabaseClient.database == nil { - return fmt.Errorf("DynamicConfig: database is not initialized") + return fmt.Errorf("task=%s, database is not initialized", common.DynamicConfigUpdate) } return nil @@ -123,23 +123,6 @@ func (databaseClient *DummyDatabaseClient) Get(env, identity string) (interface{ return nil, nil } -func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Update(data interface{}, logger *log.Entry) error { - //TODO implement me - //At point of release there is no plan to support push config to dyanmic config storage - panic("implement me") -} - -func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Delete(data interface{}, logger *log.Entry) error { - //TODO implement me - //At point of release there is no plan to support delete config to dyanmic config storage - panic("implement me") -} - -func (dynamicConfigDatabaseClient *DynamicConfigDatabaseClient) Get(env, identity string) (interface{}, error) { - //Variable renaming is done to re-purpose existing interface - return dynamicConfigDatabaseClient.dynamoClient.getDynamicConfig(env, identity, dynamicConfigDatabaseClient.database.TableName) -} - func NewAdmiralDatabaseClient(admiralConfigPath string, dynamoClientInitFunc func(string, string) (*DynamoClient, error)) (*WorkloadDatabaseClient, error) { var workloadDatabaseClient = &WorkloadDatabaseClient{}