Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quando viene creata la request per il logout, se viene specificato il binding Redirect, viene utilizzata comunque la route del binding POST dell'IdP #75

Closed
jumanji1103 opened this issue Feb 15, 2019 · 1 comment

Comments

@jumanji1103
Copy link

La funzione redirectUrl della classe LogoutRequest dovrebbe generare la request relativa al binding Redirect. Tuttavia, quando richiede il bindingLocation, richiede quello relativo al binding POST.

    public function redirectUrl($redirectTo = null) : string
    {
        $location = parent::getBindingLocation(Settings::POST, 'SLO');
        if (is_null($this->xml)) {
            $this->generateXml();
        }
        return parent::redirect($location, $redirectTo);
    }

Da correggere con:

    public function redirectUrl($redirectTo = null) : string
    {
        $location = parent::getBindingLocation(Settings::BINDING_REDIRECT, 'SLO');
        if (is_null($this->xml)) {
            $this->generateXml();
        }
        return parent::redirect($location, $redirectTo);
    }
martinadezan pushed a commit to nodopiano/spid-php-lib that referenced this issue Feb 15, 2019
@simevo
Copy link
Collaborator

simevo commented Jan 12, 2020

duplicate of #90

@simevo simevo closed this as completed Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants