Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: extract rendering functionality to separate lib/submodule #6944

Closed
pared opened this issue Nov 9, 2021 · 0 comments · Fixed by #7409
Closed

plots: extract rendering functionality to separate lib/submodule #6944

pared opened this issue Nov 9, 2021 · 0 comments · Fixed by #7409
Assignees
Labels
A: plots Related to the plots refactoring Factoring and re-factoring

Comments

@pared
Copy link
Contributor

pared commented Nov 9, 2021

I think we need to discuss extracting dvc.plots.show to a separate lib.

Why?

  1. dvc plots used to be only about Vega, and we made the user use a particular convention (saving plots as data files) in order to provide meaningful results in dvc plots show/diff commands.
  2. turns out its hard to force user's to use only one convention - hence plots: introduce support for images #6431, and ideas like plots: Add support for plotly as backend for render plots dvc-render#7
  3. loosening the plot's requirements made us focus the dvc commands on providing the data rather than a visualization as a whole, and allowed us to separate the HTML rendering from the Repo.plots methods
  4. dvclive could use rendering too - but we don't want to add whole DVC for plotting purposes only
  5. Seems like after plots: special chars handling for vega plots paths #6900 we will need to do something about generated HTML and js testing, which sounds flaky, so a separate testing suite might come in handy

Related: iterative/dvclive#61, #5980

cc @daavoo @dberenbaum

@pared pared added discussion requires active participation to reach a conclusion A: plots Related to the plots labels Nov 9, 2021
@daavoo daavoo self-assigned this Feb 14, 2022
@daavoo daavoo added this to DVC Feb 14, 2022
@daavoo daavoo moved this to Backlog in DVC Feb 14, 2022
@daavoo daavoo moved this from Backlog to In Progress in DVC Feb 14, 2022
@daavoo daavoo added refactoring Factoring and re-factoring and removed discussion requires active participation to reach a conclusion labels Feb 14, 2022
daavoo added a commit that referenced this issue Feb 21, 2022
Create separate package for rendering logic.
Fixes #6944
daavoo added a commit that referenced this issue Mar 10, 2022
Create and use separate package for rendering logic.
Closes #6944
@daavoo daavoo moved this from In Progress to Review In Progress in DVC Mar 15, 2022
daavoo added a commit that referenced this issue Mar 17, 2022
Create and use separate package for rendering logic.
Closes #6944
daavoo added a commit that referenced this issue Mar 22, 2022
Create and use separate package for rendering logic.
Closes #6944
daavoo added a commit that referenced this issue Mar 28, 2022
Create and use separate package for rendering logic.
Closes #6944
daavoo added a commit that referenced this issue Mar 28, 2022
Create and use separate package for rendering logic.
Closes #6944
Repository owner moved this from Review In Progress to Done in DVC Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: plots Related to the plots refactoring Factoring and re-factoring
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants