Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API_URL is added to UI_URL if no schema provided #7

Closed
nik123 opened this issue Mar 9, 2021 · 1 comment
Closed

API_URL is added to UI_URL if no schema provided #7

nik123 opened this issue Mar 9, 2021 · 1 comment

Comments

@nik123
Copy link
Contributor

nik123 commented Mar 9, 2021

When I run install.sh without https/https part in API_URL variable, then API_URL is added to BACKEND_URL during authorization.

Environment:

  1. Ubuntu 18.04.
  2. docker-compose 1.28.2.
  3. GitHub OAuth app.

How to reproduce:

  1. Register your OAuth application on github according to instructions.
  2. Login to private Iterative repository.
  3. Run install script with command (IP address depends on your network configuration): UI_URL=192.168.1.33:3000 API_URL=192.168.1.33:8000/api GITHUB_CLIENT_ID=<client-id> GITHUB_SECRET_KEY=<secret-key> ./install.sh
  4. Open http://192.168.1.33:3000 in you browser.
  5. Click log in button.

Result:
You will get 404 error and for a moment there will be the following address in address bar of your browser: 192.168.1.33:3000/192.168.1.33:8000/api/login/github

Expected behavior:
Not sure, probably one of two options:

  1. Do not allow UI_URL, API_URL without http/https part.
  2. Somehow mention in the docs that if no http/https part provided, then API_URL is added to UI_URL.
@omesser
Copy link

omesser commented Jan 31, 2023

This is abstracted away in our new supported installation method, using the studio helm chart (requires k8s). See: https://github.com/iterative/helm-charts
In the values structure, we take care of constructing the api/ui urls from given global.host to avoid host/url confusion
The docker-compose installation method is being phased out (still supported for existing customers until we reach out with a migration path).

@omesser omesser closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants