fix(spa): Normalize empty hrefs (jackyzha0#1695)

necauqua · web-flow · commit 46adb3596669 · 2024-12-30T09:55:18.000-08:00
A final breadcrumb has an empty href, linking to the current page, but the relative url normalization method missed those, making the link appear broken in search previews and popovers. Fixes jackyzha0#1690
diff --git a/quartz/util/path.ts b/quartz/util/path.ts
@@ -108,10 +108,10 @@ const _rebaseHtmlElement = (el: Element, attr: string, newBase: string | URL) =>
   el.setAttribute(attr, rebased.pathname + rebased.hash)
 }
 export function normalizeRelativeURLs(el: Element | Document, destination: string | URL) {
-  el.querySelectorAll('[href^="./"], [href^="../"]').forEach((item) =>
+  el.querySelectorAll('[href=""], [href^="./"], [href^="../"]').forEach((item) =>
     _rebaseHtmlElement(item, "href", destination),
   )
-  el.querySelectorAll('[src^="./"], [src^="../"]').forEach((item) =>
+  el.querySelectorAll('[src=""], [src^="./"], [src^="../"]').forEach((item) =>
     _rebaseHtmlElement(item, "src", destination),
   )
 }

Original file line number	Diff line number	Diff line change
`@@ -108,10 +108,10 @@ const _rebaseHtmlElement = (el: Element, attr: string, newBase: string \| URL) =>`
`108`	`108`	`el.setAttribute(attr, rebased.pathname + rebased.hash)`
`109`	`109`	`}`
`110`	`110`	`export function normalizeRelativeURLs(el: Element \| Document, destination: string \| URL) {`
`111`		`- el.querySelectorAll('[href^="./"], [href^="../"]').forEach((item) =>`
	`111`	`+ el.querySelectorAll('[href=""], [href^="./"], [href^="../"]').forEach((item) =>`
`112`	`112`	`_rebaseHtmlElement(item, "href", destination),`
`113`	`113`	`)`
`114`		`- el.querySelectorAll('[src^="./"], [src^="../"]').forEach((item) =>`
	`114`	`+ el.querySelectorAll('[src=""], [src^="./"], [src^="../"]').forEach((item) =>`
`115`	`115`	`_rebaseHtmlElement(item, "src", destination),`
`116`	`116`	`)`
`117`	`117`	`}`