cmake build on Windows

at least with Ninja. Try to use V8 nuget packages in FindV8.cmake

See pmed#138, pmed#171

(cherry picked from commit 5877afb)

Author: pmed

CMakeLists.txt

@@ -22,6 +22,13 @@ set(V8PP_PLUGIN_INIT_PROC_NAME "v8pp_module_init" CACHE STRING "v8pp plugin init
 set(V8PP_PLUGIN_SUFFIX ${CMAKE_SHARED_LIBRARY_SUFFIX} CACHE STRING "v8pp plugin filename suffix")
 option(V8_COMPRESS_POINTERS "Use new V8 ABI with V8_COMPRESS_POINTERS and V8_31BIT_SMIS_ON_64BIT_ARCH" ON)
 
+if(BUILD_SHARED_LIBS AND WIN32)
+	set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS true)
+endif()
+
+# put all binaries into the output dir
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR})
+
 add_subdirectory(v8pp)
 
 if(BUILD_TESTING)

cmake/FindV8.cmake

@@ -7,23 +7,54 @@
 #  V8_LIBRARIES, the libraries needed to use v8.
 #  V8_FOUND, If false, do not try to use v8.
 
-find_path(V8_INCLUDE_DIRS PATH_SUFFIXES v8 NAMES v8.h)
+if(WIN32)
+	set(ARCH ${CMAKE_VS_PLATFORM_TOOLSET_HOST_ARCHITECTURE})
+	if(NOT ARCH)
+		if(${CMAKE_HOST_SYSTEM_PROCESSOR} STREQUAL "AMD64")
+			set(ARCH x64)
+		else()
+			set(ARCH x86)
+		endif()
+	endif()
+	message(STATUS "v8-v${MSVC_TOOLSET_VERSION}-${ARCH}")
+	file(GLOB V8_NUGET_DEV_DIR LIST_DIRECTORIES TRUE
+		${CMAKE_BINARY_DIR}/v8-v${MSVC_TOOLSET_VERSION}-${ARCH}.*)
+	string(REPLACE "v8-" "v8.redist-" V8_NUGET_BIN_DIR ${V8_NUGET_DEV_DIR})
 
-find_library(V8_LIB NAMES v8)
-find_library(V8_LIBPLATFORM NAMES v8_libplatform)
-set(V8_LIBRARIES ${V8_LIB} ${V8_LIBPLATFORM})
+	set(V8_NUGET_INCLUDE_DIR ${V8_NUGET_DEV_DIR}/include)
+	set(V8_NUGET_LIB_DIR ${V8_NUGET_DEV_DIR}/lib/${CMAKE_BUILD_TYPE})
+	set(V8_NUGET_BIN_DIR ${V8_NUGET_BIN_DIR}/lib/${CMAKE_BUILD_TYPE})
+	find_file(V8_DLL v8.dll ${V8_NUGET_BIN_DIR})
+	find_file(V8_LIBPLATFORMDLL v8_libplatform.dll ${V8_NUGET_BIN_DIR})
+
+	file(GLOB V8_BINARIES ${V8_NUGET_BIN_DIR}/*)
+	message(STATUS "Copy ${V8_BINARIES} to the project output dir ${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")
+	file(COPY ${V8_BINARIES} DESTINATION ${CMAKE_RUNTIME_OUTPUT_DIRECTORY})
+else()
+endif()
+
+find_path(V8_INCLUDE_DIRS PATHS ${V8_NUGET_INCLUDE_DIR} PATH_SUFFIXES v8 NAMES v8.h)
+find_library(V8_LIB PATHS ${V8_NUGET_LIB_DIR} NAMES v8 v8.dll.lib)
+find_library(V8_LIBPLATFORM PATHS ${V8_NUGET_LIB_DIR} NAMES v8_libplatform v8_libplatform.dll.lib)
 
 # handle the QUIETLY and REQUIRED arguments and set V8_FOUND to TRUE
 # if all listed variables are TRUE, hide their existence from configuration view
 include(FindPackageHandleStandardArgs)
 find_package_handle_standard_args(V8 DEFAULT_MSG V8_INCLUDE_DIRS V8_LIB V8_LIBPLATFORM)
-mark_as_advanced(V8_INCLUDE_DIRS V8_LIBRARIES)
+mark_as_advanced(V8_INCLUDE_DIRS V8_LIB)
 
 if(V8_FOUND)
-    if(NOT TARGET V8::V8)
-        add_library(V8::V8 SHARED IMPORTED)
-	set_target_properties(V8::V8 PROPERTIES IMPORTED_LOCATION "${V8_LIB}")
-	target_include_directories(V8::V8 INTERFACE "${V8_INCLUDE_DIRS}")
-	target_link_libraries(V8::V8 INTERFACE "${V8_LIBRARIES}")
-    endif()
+	add_library(V8::v8 SHARED IMPORTED)
+	add_library(V8::libplatform SHARED IMPORTED)
+    if(WIN32)
+		set_target_properties(V8::v8 PROPERTIES
+			IMPORTED_IMPLIB ${V8_LIB} IMPORTED_LOCATION ${V8_DLL})
+		set_target_properties(V8::libplatform PROPERTIES
+			IMPORTED_IMPLIB ${V8_LIBPLATFORM} IMPORTED_LOCATION ${V8_LIBPLATFORMDLL})
+    else()
+		set_target_properties(V8::v8 PROPERTIES IMPORTED_LOCATION ${V8_LIB})
+		set_target_properties(V8::libplatform PROPERTIES IMPORTED_LOCATION ${V8_LIBPLATFORM})
+	endif()
+	target_include_directories(V8::v8 INTERFACE ${V8_INCLUDE_DIRS})
+	target_include_directories(V8::libplatform INTERFACE ${V8_INCLUDE_DIRS})
 endif()

test/CMakeLists.txt

@@ -24,9 +24,9 @@ endif()
 
 target_link_libraries(v8pp_test v8pp ${CMAKE_DL_LIBS})
 
-add_test(v8pp_test v8pp_test --version --run-tests)
+add_test(v8pp_test ${PROJECT_BINARY_DIR}/v8pp_test --version --run-tests)
 
 if(BUILD_SHARED_LIBS)
 	file(GLOB JS_TESTS *.js)
-	add_test(v8pp_js_test v8pp_test --lib-path ${PROJECT_BINARY_DIR}/plugins ${JS_TESTS})
+	add_test(v8pp_js_test ${PROJECT_BINARY_DIR}/v8pp_test --lib-path ${PROJECT_BINARY_DIR}/plugins ${JS_TESTS})
 endif()

v8pp/CMakeLists.txt

@@ -64,15 +64,15 @@ if(V8PP_HEADER_ONLY)
 	target_include_directories(v8pp INTERFACE
 		$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
 		$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
-	target_link_libraries(v8pp INTERFACE V8::V8)
+	target_link_libraries(v8pp INTERFACE V8::v8 V8::libplatform)
 else()
 	add_library(v8pp ${V8PP_HEADERS} ${V8PP_SOURCES})
 	target_compile_definitions(v8pp PUBLIC ${V8PP_DEFINES})
 	target_compile_options(v8pp PRIVATE ${V8PP_COMPILE_OPTIONS})
 	target_include_directories(v8pp PUBLIC
 		$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
 		$<INSTALL_INTERFACE:${CMAKE_INSTALL_INCLUDEDIR}>)
-	target_link_libraries(v8pp PUBLIC V8::V8)
+	target_link_libraries(v8pp PUBLIC V8::v8 V8::libplatform)
 	if(BUILD_SHARED_LIBS)
 		target_link_libraries(v8pp PUBLIC ${CMAKE_DL_LIBS})
 	endif()