Skip to content
This repository has been archived by the owner on Jun 5, 2023. It is now read-only.

Update Elasticsearch and Python Client #189

Open
fivegrant opened this issue Jul 25, 2022 · 1 comment
Open

Update Elasticsearch and Python Client #189

fivegrant opened this issue Jul 25, 2022 · 1 comment
Labels
warning Issue that is not pressing but should be noted wontfix This will not be worked on

Comments

@fivegrant
Copy link
Contributor

Elasticsearch is deprecating the use of query for body as per this elasticsearch issue. This isn't breaking at the moment, but might cause problems if libraries are updated in the future.

The part of the issue that discusses this:

The body parameter for APIs are deprecated
For JSON requests each field within the top-level JSON object will become it's own parameter of the API with full type hinting

# ✅ New usage:
es.search(query={...})

# ❌ Deprecated usage:
es.search(body={"query": {...}})
@fivegrant fivegrant added warning Issue that is not pressing but should be noted wontfix This will not be worked on labels Jul 25, 2022
@fivegrant
Copy link
Contributor Author

Updating the Elasticsearch client for Python might be a pain because it might cause a product mismatch with Elasticsearch: The client noticed that the server is not Elasticsearch and we do not support this unknown product. Seems like Elasticsearch itself would also have to be updated

@fivegrant fivegrant changed the title Deprecated use of body when querying elasticsearch. Update Elasticsearch and Python Client Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
warning Issue that is not pressing but should be noted wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant