Commits

Branch selector

 master

User selector

All users

Datepicker

All time

Commit History

Commits on May 10, 2024

• Update intro to emphasize "Why?"

  Show description for 50d0e52
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  50d0e52

• Use {.bad}/{.good} to highlight bad/good examples with color.

  Show description for 900d9b0
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  900d9b0

Commits on Apr 24, 2024

• Tweak some permalinks to use #kebab-case instead of #snake_case or #nospacingatall.

  Show description for fde5fd4
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  fde5fd4

Commits on Mar 26, 2024

• Add examples of minor suggestions to the "LGTM With Comments" section.

  Show description for a54db24
  

  kluever

  authored and

  copybara-github

  committed
  a54db24

Commits on Dec 4, 2023

• Emphasize that tests are expected by default.

  Show description for 82e7d4b
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  82e7d4b

Commits on Nov 30, 2023

• No public description

  Show description for 6846311
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  6846311

Commits on Nov 23, 2023

• First, "rpc" is an acronym, so it should be capitalized. Second, we demand first line be a "complete sentence", so it should start with a capital letter.

  Show description for 27bbdae
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  27bbdae

Commits on Jul 17, 2023

• Fixed annotation for code-health-devguide-copybara to pick up correct file contents in small-cls

  Show description for f59560f
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  f59560f

Commits on Jul 14, 2023

• Add more guidance and benefits of planning out and writing self-contained CLs.

  Show description for ae06fd0
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  ae06fd0

Commits on May 8, 2023

• Add guidance for usage of description tags (e.g. [tag], #tag).

  Show description for 36833b7
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  36833b7

Commits on Aug 17, 2022

• Added section related to comments severity

  Show description for 537567e
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  537567e

Commits on Jun 27, 2022

• Automated formatting changes.

  Show description for ab034bf
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  ab034bf

Commits on Mar 31, 2022

• Update "Think for Yourself" to "Think Collaboratively".

  Show description for 716687a
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  716687a

• Be inclusive of Privacy anywhere Security is referenced.

  Show description for 3e6ba5c
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  3e6ba5c

Commits on Feb 8, 2022

• For cross-tz reviews give the author enough time to respond before the end of the day.

  Show description for 0ab08d6
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  0ab08d6

Commits on Jan 10, 2022

• Internal change

  Show description for 6cebf15
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  6cebf15

Commits on Oct 26, 2021

• Fix punctuation in go/review-speed:

  Show description for 3bb64aa
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  3bb64aa

Commits on Oct 7, 2021

• Change eng-practices Github Pages theme to jekyll-theme-primer.

  Show description for 5dfc4de
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  5dfc4de

Commits on Jul 9, 2021

• Fixing broken link.

  Show description for deaff2f
  

  adambender

  authored and

  copybara-github

  committed
  deaff2f

Commits on Jul 7, 2021

• Clarify what the "rest" is contrasting in Google eng-practices documentation.

  Show description for e537051
  

  Michael Sheely

  authored and

  copybara-github

  committed
  e537051

Commits on Apr 28, 2021

• Internal change

  Show description for 27fbdb5
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  27fbdb5

Commits on Mar 18, 2021

• Add tips for handling partial reviews.

  Show description for 3a17d63
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  3a17d63

• Internal change

  Show description for 40e621a
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  40e621a

Commits on Mar 10, 2021

• Update permalinks on "What to look for..." to use dashes instead of underscores.

  Show description for cea9d7a
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  cea9d7a

Commits on Nov 18, 2020

• Remove disrespectful terminology ("sanity check")

  Show description for e849e00
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  e849e00

Commits on Oct 27, 2020

• Clarify what it means for the style guide to be a recommendation.

  Show description for b8bfaab
  

  amalloy

  authored and

  copybara-github

  committed
  b8bfaab

Commits on Aug 4, 2020

• Add missing comma.

  Show description for eaff1ef
  

  ninabikes

  authored and

  copybara-github

  committed
  eaff1ef

• Internal change

  Show description for 68b39c4
  

  adambender

  authored and

  copybara-github

  committed
  68b39c4

• Internal change

  Show description for fe113b3
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  fe113b3

Commits on Jul 31, 2020

• Merge pull request #14 from alanyee/patch-1

  Show description for f81aa27
  adambender

  authored
  f81aa27

• Merge pull request #30 from michaelrbock/patch-2

  Show description for 5bc2e3a
  adambender

  authored
  5bc2e3a

• Merge branch 'master' into patch-2

  adambender

  authored
  5c8e8a0

• Merge pull request #26 from fractalists/master

  Show description for c203258
  adambender

  authored
  c203258

Commits on Jul 30, 2020

• Make the "test code" section clearer about the expectation that CLs should include relevant tests.

  Show description for 3f527b1
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  3f527b1

Commits on Jul 28, 2020

• Fix link for Respectful Code Reviews: https://chromium.googlesource.com/chromium/src/+/master/docs/cr_respect.md

  Show description for 5e85129
  

  code-health-devguide-copybara

  authored and

  copybara-github

  committed
  5e85129

Pagination

PreviousNext