Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Settings should be loadable from the environment #12

Open
newbeeDotA opened this issue Dec 13, 2024 · 1 comment
Open

Enhancement: Settings should be loadable from the environment #12

newbeeDotA opened this issue Dec 13, 2024 · 1 comment

Comments

@newbeeDotA
Copy link

Enhancement request title: Settings should be loadable from the environment
Use case: Load settings from the environment in containerized environment for better synchronization between containers and a easy to deploy application.
Current behavior: Settings cant be loaded form the environment, only from the system.json file.
Requested behavior: Load simple settings (strings, bools, numbers) from the environment.
Recommended implementation: go through all applicable settings and check for a environment var that corresponds with it and overwrite the loaded setting.
Usefulness of the enhancement: makes containerized applications more easy to deploy without changing the system.json file for each deployment.

PS: Iam already on developing something like this at the moment, so i could do a PR soon on this.

@jchristn
Copy link
Owner

Hi @newbeeDotA thanks, I appreciate the suggestion. Main reason I haven't done it is it is easy enough to mount a file/folder into the container at startup. I'd be happy to take a PR on this when you have one ready. Enjoy the holiday break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants