Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't download 'no image' images for people #74

Closed
sjorge opened this issue Jul 12, 2024 · 4 comments
Closed

Don't download 'no image' images for people #74

sjorge opened this issue Jul 12, 2024 · 4 comments

Comments

@sjorge
Copy link
Contributor

sjorge commented Jul 12, 2024

Screenshot 2024-07-12 at 12 59 59

Ref: https://anilist.co/staff/115997/Kinosaki-Michiru

Some people will have a no image image downloaded by this provider. These should not be downloaded, giving other providers that do have an image a chance to download one.
@HansLehnert
Copy link
Contributor

I had addressed this in #56, but the PR got closed for seemingly no reason...

@sjorge
Copy link
Contributor Author

sjorge commented Aug 10, 2024

Weird that it got closed, maybe aks why in the PR. Maybe it was an error.

@nielsvanvelzen
Copy link
Member

The pull request was targeting the unstable branch which was auto-deleted once 10.9 was released. I'm confident it was accidental. You can re-open it but target the master branch instead!

@sjorge
Copy link
Contributor Author

sjorge commented Sep 30, 2024

PR got merged, closing

@sjorge sjorge closed this as completed Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sjorge @nielsvanvelzen @HansLehnert