Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable shortcuts #1

Closed
danifr opened this issue Dec 12, 2017 · 9 comments
Closed

Configurable shortcuts #1

danifr opened this issue Dec 12, 2017 · 9 comments

Comments

@danifr
Copy link

danifr commented Dec 12, 2017

First thanks for this amazing addon this is exactly what I was looking for 🥇 👍
Any plans of adding the option to allow the usesr to specify their own shortcuts?

Thanks a lot again!

@jerosa
Copy link
Owner

jerosa commented Dec 12, 2017

First of all, thank you for your kind words. ^^

Answering the question, yes. Actually I'm trying to implement it but it's my first addon and I'm having problems storing the user preferences and make the addon recognize the custom shortcuts.

@jerosa jerosa self-assigned this Dec 12, 2017
jerosa added a commit that referenced this issue Dec 21, 2017
- Added option page
- Communication content and background script
- Content script catches keycombos
@jerosa
Copy link
Owner

jerosa commented Dec 21, 2017

New approach with customizable shortcuts until mozilla implemets UI for shortcuts

@p-p-q
Copy link

p-p-q commented Jan 2, 2018

Thank you for creating this. It does what I want and nothing more, that's how everything should be.
Can you give me a hint on how to build a .xpi file from the contents of this repo? I changed the hotkeys in the .json file so I need to rebuild. Just saw your new commit but I still need to build this myself.

@jerosa
Copy link
Owner

jerosa commented Jan 2, 2018

@p-p-q glad I was able to help you.

Since still there is no official way to costumize shortcuts I recommend you to use the master branch and change there the keys on the .json file. The development branch is just a "temporary workaround" and needs improvements.

The .xpi is just a compressed file so for the build just compress the repository into one file with one of the following extensions: .zip, .xpi, .crx, .xml.

@p-p-q
Copy link

p-p-q commented Jan 2, 2018

@TsunDoge Thanks, I tried to do this. I took all the files from this repo, edited the .json and put everything in a .zip. However, Firefox will not install it and says it is damaged? Maybe something is missing?

@jerosa
Copy link
Owner

jerosa commented Jan 2, 2018

That's probably because you have misconfigured the shortcuts or some of them are used by the explorer.
Try others keycombos to check if that's the issue. @p-p-q

@p-p-q
Copy link

p-p-q commented Jan 2, 2018

@TsunDoge I tried again with your unmodified .json, it gives me the same error message. The .xpi you uploaded to addons.mozilla.org has a META-INF directory, is that required?

@jerosa
Copy link
Owner

jerosa commented Jan 2, 2018

The META-INF directory it is not needed. The original files should not give you any error.

Try again downloading the project, then decompress it and visit about:debugging, click on "load temporary addon", and finally select the manifest.json file.
Firefox should load the addon correctly.

@jerosa
Copy link
Owner

jerosa commented Apr 26, 2018

I reopen this issue due to mozilla providing a method to change the webextensions shortcuts

Also found an interesting library which build a custom UI and I'll it use until a similar one land on Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants