Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript icon colors are inconsistent #518

Closed
miguelsolorio opened this issue Dec 3, 2018 · 1 comment · Fixed by #530
Closed

TypeScript icon colors are inconsistent #518

miguelsolorio opened this issue Dec 3, 2018 · 1 comment · Fixed by #530

Comments

@miguelsolorio
Copy link

Ref microsoft/vscode#64147

img

I think *.test.ts should definitely be yellow for consistency with the other... so that I can easily discriminate real source files and test files (I filed this issue because I'd prefer test which is more descriptive as a filename rather than spec, if it's not blue!).

Other icon themes generally seem to treat these two as the same.

@goenning
Copy link

goenning commented Mar 11, 2019

I'd say that .spec.tsx and .test.tsx should also be yellow for the same reason. They're currently blue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants