no AH01588 for ap_get_client_block + CL over limit

covener · covener · commit 1d572ae866d1 · 2023-07-24T17:31:38.000Z
git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1911249 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/docs/log-message-tags/next-number b/docs/log-message-tags/next-number
@@ -1 +1 @@
-10483
+10484
diff --git a/modules/http/http_filters.c b/modules/http/http_filters.c
@@ -1561,7 +1561,14 @@ AP_DECLARE(int) ap_setup_client_block(request_rec *r, int read_policy)
     }
 
     if (limit_req_body > 0 && (r->remaining > limit_req_body)) {
-        /* will be logged when the body is discarded */
+        /* 01588 msg in HTTP_IN filter will be skipped for a connection-dropping status,
+         * so log a similar message here.
+         */
+        ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(10483)
+                "Requested content-length of %" APR_OFF_T_FMT
+                " is larger than the configured limit"
+                " of %" APR_OFF_T_FMT, r->remaining, limit_req_body);
+
         return HTTP_REQUEST_ENTITY_TOO_LARGE;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1561,7 +1561,14 @@ AP_DECLARE(int) ap_setup_client_block(request_rec *r, int read_policy)`
`1561`	`1561`	`}`
`1562`	`1562`
`1563`	`1563`	`if (limit_req_body > 0 && (r->remaining > limit_req_body)) {`
`1564`		`- /* will be logged when the body is discarded */`
	`1564`	`+ /* 01588 msg in HTTP_IN filter will be skipped for a connection-dropping status,`
	`1565`	`+ * so log a similar message here.`
	`1566`	`+ */`
	`1567`	`+ ap_log_rerror(APLOG_MARK, APLOG_INFO, 0, r, APLOGNO(10483)`
	`1568`	`+ "Requested content-length of %" APR_OFF_T_FMT`
	`1569`	`+ " is larger than the configured limit"`
	`1570`	`+ " of %" APR_OFF_T_FMT, r->remaining, limit_req_body);`
	`1571`	`+`
`1565`	`1572`	`return HTTP_REQUEST_ENTITY_TOO_LARGE;`
`1566`	`1573`	`}`
`1567`	`1574`