Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

模型结构图片LLM-structure与实际代码不符，一个小问题~ #191

Closed
sinaitic opened this issue Feb 18, 2025 · 2 comments
Closed

模型结构图片LLM-structure与实际代码不符，一个小问题~ #191

sinaitic opened this issue Feb 18, 2025 · 2 comments

Comments

@sinaitic
Copy link

首先非常感谢作者的项目！
我在学习的过程中发现作者的attention部分的代码使用的是GQA，而图片中写的却是MHSA
@jingyaogong
Copy link
Owner

jingyaogong commented Feb 18, 2025 •
edited
Loading

是的，u are right，MHSA已经进化成了GQA😆

@jingyaogong
Copy link
Owner

updated

see dcf5fcd

@IOLOII IOLOII mentioned this issue Feb 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jingyaogong @sinaitic