forked from binler/react-bits
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy path05.mutating-state.jsx
69 lines (58 loc) · 1.28 KB
/
05.mutating-state.jsx
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
/**
* Mutating State without setState()
*
* - Causes state changes without making component re-render
* - Whenever setState gets called in future, the mutated state gets applied.
*
* @Reference:
* React Design Patterns and best practices by Michele Bertoli
*/
// BAD
class SampleComponent extends Component {
constructor(props) {
super(props);
this.state = {
items: ['foo', 'bar']
};
this.handleClick = this.handleClick.bind(this);
}
handleClick() {
// BAD: We mutate state here
this.state.items.push('lorem');
this.setState({
items: this.state.items
});
}
render() {
return (
<div>
{this.state.items.length}
<button onClick={this.handleClick}>+</button>
</div>
)
}
}
// GOOD
class SampleComponent extends Component {
constructor(props) {
super(props);
this.state = {
items: ['foo', 'bar']
};
this.handleClick = this.handleClick.bind(this);
}
handleClick() {
// We update using setState() - concat return new array after appending new item.
this.setState({
items: this.state.items.concat('lorem')
});
}
render() {
return (
<div>
{this.state.items.length}
<button onClick={this.handleClick}>+</button>
</div>
)
}
}