Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should React be a peerDependency instead of a dependency? #15

Open
albertstill opened this issue Jun 12, 2018 · 2 comments
Open

Should React be a peerDependency instead of a dependency? #15

albertstill opened this issue Jun 12, 2018 · 2 comments

Comments

@albertstill
Copy link

No description provided.

@albertstill
Copy link
Author

Any update on this @jmsardina, should be a straight forward fix, just remove react from dependencies and add "peerDependencies": { "react": "^15.5.4" } in package.json? Probably will need to be a major release to be safe.

@jmsardina jmsardina mentioned this issue Jan 15, 2019
Merged
3 tasks
@jmsardina
Copy link
Owner

@albertstill I've opened a PR to set React as a peer dependency and to upgrade to React 16, while continuing to support the previous version. Would you mind taking a look? #18

Planning to release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@albertstill @jmsardina