From da05c8db75799f2e88e722fce3bdda0d667ce361 Mon Sep 17 00:00:00 2001 From: Jongsoo Park <jongsoo@fb.com> Date: Sat, 10 Oct 2020 20:57:47 -0700 Subject: [PATCH] cleanup temp interface (#435) Summary: Pull Request resolved: https://github.com/pytorch/FBGEMM/pull/435 As title Reviewed By: dskhudia Differential Revision: D24197727 fbshipit-source-id: b660276060ae3250ac5a6844a2b7551797fd1cf0 --- include/fbgemm/FbgemmEmbedding.h | 8 -------- src/SparseAdagrad.cc | 24 ------------------------ 2 files changed, 32 deletions(-) diff --git a/include/fbgemm/FbgemmEmbedding.h b/include/fbgemm/FbgemmEmbedding.h index 3d2825bbe9..ca153e513c 100644 --- a/include/fbgemm/FbgemmEmbedding.h +++ b/include/fbgemm/FbgemmEmbedding.h @@ -179,14 +179,6 @@ GenerateSparseAdaGrad( int prefetch = 16, bool use_weight_decay = false); -template <typename IndexType> -FBGEMM_API typename SparseAdaGradSignature<IndexType>::NewType -GenerateSparseAdaGradNew( - int block_size, // number of parameters per row - bool rowwise = false, - int prefetch = 16, - bool use_weight_decay = false); - // RowWiseSparseAdaGrad fused with SLS gradient // Weights can be either float or float16 template < diff --git a/src/SparseAdagrad.cc b/src/SparseAdagrad.cc index 69ea1696d6..99b68224fb 100644 --- a/src/SparseAdagrad.cc +++ b/src/SparseAdagrad.cc @@ -912,28 +912,4 @@ GenerateSparseAdaGrad<std::int32_t>( int prefetch, bool use_weight_decay); -template <typename IndexType> -typename SparseAdaGradSignature<IndexType>::NewType GenerateSparseAdaGradNew( - int block_size, - bool rowwise, - int prefetch, - bool use_weight_decay) { - return GenerateSparseAdaGrad<IndexType>( - block_size, rowwise, prefetch, use_weight_decay); -} - -template FBGEMM_API typename SparseAdaGradSignature<std::int64_t>::NewType -GenerateSparseAdaGradNew<std::int64_t>( - int block_size, // number of parameters per rows - bool rowwise, - int prefetch, - bool use_weight_decay); - -template FBGEMM_API typename SparseAdaGradSignature<std::int32_t>::NewType -GenerateSparseAdaGradNew<std::int32_t>( - int block_size, // number of parameters per rows - bool rowwise, - int prefetch, - bool use_weight_decay); - } // namespace fbgemm