-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is Stupid-Table-Plugin browser support in November 2014 ? #128
Comments
Hey Adrien, You can run the unittests in any browser by visiting https://rawgit.com/joequery/Stupid-Table-Plugin/master/tests/test.html I haven't made any official statement of browser support, but I can look into some sort of service that will let me test multiple browser versions. |
Hi Joe Thanks for the quick feedback. That's great, I'll run this test in a few different browsers & will post back the results I got. Yes, maybe browserstack, saucelabs, ghostLab, or spoon could do the job. |
👍 Thank you for the service recommendations |
Test results on different setups:
1: test fix needed as test 13 fails. Fix this by getting the value of the inline style before acting on the table & then compare it with the inline style after it. Explanation: IE modifies the inline styling properties (see more below). IE modifies the inline styling propertiesBasically, IE modifies the inline styling for the table's tbody, and adds "currentColor; border-image: none;". God knows why.... IE will always be IE. ConclusionIt looks all pretty good to me. More browser testing across device would be nice (IE9, browsers on Android tablets & possibly other Android mobiles). |
This fixes issues with tests 5 and 18 as mentioned in joequery#128 Explanation: slow browsers need more time to apply expected changes.
IE has some strange behavior. It modifies the value of the inline styling, as fully explained on joequery#128 Best thing to avoid this silly problem is to simply compare the inline styling before any JS is run "on the relevant table element". And then compare this value with the one after the relevant JS is run.
Adrien, Thank you so much for your contributions! I appreciate your time and thorough research. I'll be sure to add browser support to the docs. The docs need an overhaul anyhow. |
You're welcome. Nice one, this will be appreciated I'm sure :) |
Hi,
I cannot find any clear statement regarding browser support.
I did a bit of research but could not find anything.
Ideally I am looking for an official statement from the creator of the plugin or by someone who has been using this plugin on Live systems for a while.
Thanks in advance,
Adrien
The text was updated successfully, but these errors were encountered: