Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoI example broken #15

Closed
jonathf opened this issue Sep 24, 2016 · 4 comments
Closed

QoI example broken #15

jonathf opened this issue Sep 24, 2016 · 4 comments

Comments

@jonathf
Copy link
Owner

jonathf commented Sep 24, 2016

@flo2k I am working on a refactor of the code, I am noticing that your code example for QoI_Dist is incomplete:

Examples:
    >>> cp.seed(1000)
    >>> x = cp.variable(1)
    >>> poly = cp.Poly([x])
    >>> qoi_dist = cp.QoI_Dist(poly, dist)
    >>> print(qoi_dist[0].pdf([-0.75, 0., 0.75]))
    [  1.27794383e-123   3.99317083e+000   1.16692607e-100]

What should dist be defined as to complete this example?

@flo2k
Copy link
Collaborator

flo2k commented Sep 25, 2016

Hi Jonathan,

I think, that I have time during the week to answer your question.

Best,

Florian

Am 24.09.2016 um 22:55 schrieb Jonathan Feinberg:

@flo2k https://github.com/flo2k I am working on a refactor of the
code, I am noticing that your code example for |QoI_Dist| is incomplete:

|Examples: >>> cp.seed(1000) >>> x = cp.variable(1) >>> poly =
cp.Poly([x]) >>> qoi_dist = cp.QoI_Dist(poly, dist) >>>
print(qoi_dist[0].pdf([-0.75, 0., 0.75])) [ 1.27794383e-123
3.99317083e+000 1.16692607e-100] |

What should |dist| be defined as to complete this example?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#15, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABE8-P6N7m9zRe6XM85LiQ0bRNGCYKaWks5qtY5CgaJpZM4KFvks.

@flo2k
Copy link
Collaborator

flo2k commented Sep 27, 2016

Hi @jonathf you can find the solution in #17

@flo2k
Copy link
Collaborator

flo2k commented Sep 27, 2016

I do also have some unit tests written with python unittest framework. Do you know a place where I can put it in an let it automatically run from the CI system?

@jonathf
Copy link
Owner Author

jonathf commented Sep 29, 2016

Thank you.

As for the unittests, you can place them in chaospy/tests which you can find in the development branch. It is much appreciated.

@jonathf jonathf closed this as completed Sep 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants