Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predictive entropy search without sampling #19

Closed
xunhuan-li opened this issue Mar 2, 2019 · 1 comment
Closed

predictive entropy search without sampling #19

xunhuan-li opened this issue Mar 2, 2019 · 1 comment

Comments

@xunhuan-li
Copy link

Hi there,

Thanks for your package!
We noticed that the the predictive entropy search in the file acquisition.py is different from the method introduced by the paper "Predictive Entropy Search for Efficient Global Optimization of Black-box Functions".

It seems, the method in the package only calculates the approximation of H[p(y|Dn; x; x*)] and did not sample x* based on estimated posterior distribution and take average of the approximated H[p(y|Dn; x; x*)].

@josejimenezluna
Copy link
Owner

Hello @xunhuan-li,

If you implement said acquisition function I'd gladly accept a PR 😁

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants