-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lkml goes into infinite loop #91
Comments
Hi @EyalDlph, can you please share some sample LookML to help me reproduce this? |
a file with a single semi-colon will do. |
In what context would a single semicolon not in double-quotes and not part of a SQL expression be valid LookML? It's not enough to have a file with a single semicolon. For example, this parses perfectly well:
Please provide an example. |
Of course. This is not valid LookML. This is why I was expecting the
|
when there is a single semi-colon (
;
) in the file,lkml
goes into infinite loop.In
lexer.py
,Lexer.scan()
, around line 78, is peeking ahead to look for double semi-columns (;;
). If it does find it, it just keeps looking forever, not advancing the scan index and not throwing an exceptionMy quick-fix was to throw an exception if under
scan()
the lexer encounters a single semi-colon:The text was updated successfully, but these errors were encountered: