From 7d46fe49bc3ce057dd431e38db8ecf60508ce54d Mon Sep 17 00:00:00 2001
From: Bernardo Lares <bernardolares@fb.com>
Date: Fri, 20 May 2022 09:38:36 -0500
Subject: [PATCH] feat: include time units used on adstock plots

---
 R/R/plots.R          |  4 ++--
 R/R/transformation.R | 20 ++++++++++----------
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/R/R/plots.R b/R/R/plots.R
index 1d0e566bb..22d8a5c1f 100644
--- a/R/R/plots.R
+++ b/R/R/plots.R
@@ -342,7 +342,7 @@ robyn_onepagers <- function(InputCollect, OutputCollect, select_model = NULL, qu
           scale_y_percent(limit = c(0, 1)) +
           labs(
             title = "Geometric Adstock: Fixed Decay Rate Over Time",
-            y = NULL, x = NULL
+            y = sprintf("Thetas [by %s]", InputCollect$intervalType), x = NULL
           )
       }
       if (InputCollect$adstock %in% c("weibull_cdf", "weibull_pdf")) {
@@ -356,7 +356,7 @@ robyn_onepagers <- function(InputCollect, OutputCollect, select_model = NULL, qu
           theme_lares(legend = "none", grid = "Xx") +
           labs(
             title = paste0("Weibull Adstock ", wb_type, ": Flexible Decay Rate Over Time"),
-            x = "Time Unit", y = NULL
+            x = sprintf("Time unit [%ss]", InputCollect$intervalType), y = NULL
           )
       }
 
diff --git a/R/R/transformation.R b/R/R/transformation.R
index aeaaec967..329adb9ed 100644
--- a/R/R/transformation.R
+++ b/R/R/transformation.R
@@ -215,11 +215,11 @@ plot_adstock <- function(plot = TRUE) {
       geom_hline(yintercept = 0.5, linetype = "dashed", color = "gray") +
       geom_text(aes(x = max(x), y = 0.5, vjust = -0.5, hjust = 1, label = "Halflife"), colour = "gray") +
       labs(
-        title = "Geometric adstock (fixed decay rate)",
+        title = "Geometric Adstock\n(fixed decay rate)",
         subtitle = "Halflife = time until effect reduces to 50%",
-        x = "time unit",
+        x = "Time unit",
         y = "Media decay accumulated"
-      )
+      ) + theme_lares(pal = 2)
 
     ## plot weibull
     weibullCollect <- list()
@@ -252,11 +252,11 @@ plot_adstock <- function(plot = TRUE) {
       geom_hline(yintercept = 0.5, linetype = "dashed", color = "gray") +
       geom_text(aes(x = max(x), y = 0.5, vjust = -0.5, hjust = 1, label = "Halflife"), colour = "gray") +
       labs(
-        title = "Weibull adstock CDF vs PDF (flexible decay rate)",
+        title = "Weibull Adstock CDF vs PDF\n(flexible decay rate)",
         subtitle = "Halflife = time until effect reduces to 50%",
-        x = "time unit",
+        x = "Time unit",
         y = "Media decay accumulated"
-      )
+      ) + theme_lares(pal = 2)
     return(wrap_plots(A = p1, B = p2, design = "ABB"))
   }
 }
@@ -279,7 +279,7 @@ plot_saturation <- function(plot = TRUE) {
     alphaSamp <- c(0.1, 0.5, 1, 2, 3)
     gammaSamp <- c(0.1, 0.3, 0.5, 0.7, 0.9)
 
-    ## plot alphas
+    ## Plot alphas
     hillAlphaCollect <- list()
     for (i in 1:length(alphaSamp)) {
       hillAlphaCollect[[i]] <- data.table(
@@ -295,9 +295,9 @@ plot_saturation <- function(plot = TRUE) {
       labs(
         title = "Cost response with hill function",
         subtitle = "Alpha changes while gamma = 0.5"
-      )
+      ) + theme_lares(pal = 2)
 
-    ## plot gammas
+    ## Plot gammas
     hillGammaCollect <- list()
     for (i in 1:length(gammaSamp)) {
       hillGammaCollect[[i]] <- data.table(
@@ -313,7 +313,7 @@ plot_saturation <- function(plot = TRUE) {
       labs(
         title = "Cost response with hill function",
         subtitle = "Gamma changes while alpha = 2"
-      )
+      ) + theme_lares(pal = 2)
 
     return(p1 + p2)
   }