From ce3a1323ede070a05a3d99fc866ee38f60e53ef8 Mon Sep 17 00:00:00 2001 From: cmbrose <5447118+cmbrose@users.noreply.github.com> Date: Fri, 3 Jun 2022 14:05:24 -0500 Subject: [PATCH] Remove TODOs --- internal/codespaces/ssh.go | 1 - internal/codespaces/states.go | 1 - 2 files changed, 2 deletions(-) diff --git a/internal/codespaces/ssh.go b/internal/codespaces/ssh.go index 50dabd62091..0c81c4f32ff 100644 --- a/internal/codespaces/ssh.go +++ b/internal/codespaces/ssh.go @@ -56,7 +56,6 @@ func NewRemoteCommand(ctx context.Context, tunnelPort int, destination string, s // newSSHCommand populates an exec.Cmd to run a command (or if blank, // an interactive shell) over ssh. func newSSHCommand(ctx context.Context, port int, dst string, cmdArgs []string) (*exec.Cmd, []string, error) { - // TODO: Read SSH key from ~/.ssh/codespace and pass as argument with -i connArgs := []string{"-p", strconv.Itoa(port), "-o", "NoHostAuthenticationForLocalhost=yes"} // The ssh command syntax is: ssh [flags] user@host command [args...] diff --git a/internal/codespaces/states.go b/internal/codespaces/states.go index f2ec0dcd9c0..887735caf6d 100644 --- a/internal/codespaces/states.go +++ b/internal/codespaces/states.go @@ -60,7 +60,6 @@ func PollPostCreateStates(ctx context.Context, progress progressIndicator, apiCl progress.StartProgressIndicatorWithLabel("Fetching SSH Details") defer progress.StopProgressIndicator() - // TODO: This shouldn't care about the key remoteSSHServerPort, sshUser, err := session.StartSSHServer(ctx) if err != nil { return fmt.Errorf("error getting ssh server details: %w", err)