Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove default view/layout sizes #161

Open
jrtom opened this issue Nov 29, 2017 · 1 comment
Open

remove default view/layout sizes #161

jrtom opened this issue Nov 29, 2017 · 1 comment

Comments

@jrtom
Copy link
Owner

jrtom commented Nov 29, 2017

At the moment, JUNG provides a default size of 600x600 for layouts and views.

In my opinion, we should not be providing any defaults: if users want to create a visualization, they need to specify how big it should be. Ideally, this should be baked into how the visualization is created, but it may be necessary or appropriate to add Preconditions checks to validate that dimensions have been set.

This is partially a matter of practicality: 600x600 is a much smaller piece of screen real estate than it used to be when JUNG was created (because pixels are a lot smaller). If we were to continue to have a default, we might well want to change it to be a reasonable size. However, as long as we have a default, users may depend on that default being a specific size.

More fundamentally, though, I think that it's a mistake to specify a default when we can't make a meaningful informed choice on the user's behalf.

@tomnelson
Copy link
Contributor

I have a PR ready for this but it has to merge after the lens PR #160
It also adds javadocs and makes the default spatial structure (or lack of) settable with a property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants