Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action support to build #30

Open
johnsca opened this issue Oct 22, 2015 · 2 comments
Open

Add action support to build #30

johnsca opened this issue Oct 22, 2015 · 2 comments

Comments

@johnsca
Copy link
Contributor

johnsca commented Oct 22, 2015

To support reactive actions, we should create boilerplate action executables based on the contents of actions.yaml during the charm build process.

@bcsaller
Copy link
Contributor

Skeptical. Each file should generally be owned by one layer. This would be a generated file that should be hand edited. We could do this, but it is more of a template pattern than the current model we have.

@johnsca
Copy link
Contributor Author

johnsca commented Oct 22, 2015

I don't think it should be hand edited at all. It should have the exact same contents as the hooks generated by interface layers. The custom code for the actions would live under reactive/ like all other reactive code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants