Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] Remove "2" from the generated Angular[2] <- library created names #33

Closed
MarkPieszak opened this issue Jan 28, 2017 · 3 comments

Comments

@MarkPieszak
Copy link
Contributor

MarkPieszak commented Jan 28, 2017

Since going forward Angular2 is just going to be called Angular, it might be best to make sure people call their libraries by that (angular-libraryname), or the other common shortcut ngx-libraryname.

http://angularjs.blogspot.com/2016/12/ok-let-me-explain-its-going-to-be.html

Should we make some quick updates to the generator so we make sure people start going that route?
Maybe even just a note to let people know about new naming conventions?

Just trying to help! :)

@MarkPieszak MarkPieszak changed the title [proposal] Remove "2" from the generated Angular[2] <- libraries created [proposal] Remove "2" from the generated Angular[2] <- library created names Jan 28, 2017
@jvandemo
Copy link
Owner

@MarkPieszak — Great idea, I have prepared PR #35.

Before I merge the PR, do you feel anything else would need to be updated?

Thanks in advance!

@MarkPieszak
Copy link
Contributor Author

So far so good, if anything else sticks out I'll make some PRs!
🥇 love this generator.

@jvandemo
Copy link
Owner

@MarkPieszak — Awesome, thank you for your help and kind feedback. Much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants