buck2: test: run the starlark linter first

Summary:
- it's quite fast
- it'll show first in the logs, and considering people not familiar with our
  jobs are more likely to break it, that seems better (because we should be able
  to expect our team to actually read the full error).

Reviewed By: IanChilds

Differential Revision: D43973505

fbshipit-source-id: 566f88acb6d9d97fa71a04f5816b4f36931f70e1

test.py

@@ -452,6 +452,10 @@ def main() -> None:
         package_args.append("--workspace")
         package_args.extend([f"--exclude={p.rstrip('/')}" for p in args.exclude])
 
+    if package_args == [] and not (args.lint_rust_only or args.rustfmt_only):
+        with timing():
+            starlark_linter()
+
     if not (args.rustfmt_only or args.lint_starlark_only):
         with timing():
             clippy(package_args, args.clippy_fix)
@@ -460,10 +464,6 @@ def main() -> None:
         with timing():
             rustfmt(buck2_dir, args.ci)
 
-    if package_args == [] and not (args.lint_rust_only or args.rustfmt_only):
-        with timing():
-            starlark_linter()
-
     if not (
         args.lint_only
         or args.lint_rust_only