Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase format presision of Code to Test Ratio #230

Closed
atsushi-ishibashi opened this issue Jun 10, 2023 · 4 comments
Closed

Increase format presision of Code to Test Ratio #230

atsushi-ishibashi opened this issue Jun 10, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@atsushi-ishibashi
Copy link

atsushi-ishibashi commented Jun 10, 2023

It takes a lot of time and effort to increase the test coverage by 10%. Sometimes it is impossible to achieve it, for example from 80% to 90% and from 90 to 100.
Why don't we use 2 or 3 decimal places as default? In my case, this change will motivate me to write test codes.
This may break changes but I think it won't change any system behaviors.

If you agree the proposal, I'll make a pull-request👍
https://github.com/k1LoW/octocov/blob/bdda036c59ac40b949f6b76f6e4f741e2606763a/report/report.go#LL111C32-L111C36

@atsushi-ishibashi
Copy link
Author

When Coverage show up, my issue will be resolved👍 But in my repository, sometimes Coverage doesn't show.
Sorry for that I cannot share the detail because it is private repository.

@k1LoW
Copy link
Owner

k1LoW commented Jun 11, 2023

Thank you for your report!

Increase format presision of Code to Test Ratio

When Coverage show up, my issue will be resolved

Is this Issue about Coverage? Or is it about Code to Test Ratio ?

Why don't we use 2 or 3 decimal places as default?

But in my repository, sometimes Coverage doesn't show.

Is it a decimal point? Or is it a problem that is not displayed?

@atsushi-ishibashi
Copy link
Author

atsushi-ishibashi commented Jun 11, 2023

Thank you for your reply.

the issue is about Code to Test Ratio.

Is it a decimal point? Or is it a problem that is not displayed?

The problem is that coverage is not displayed.

This is metrics report when I created this issue.
Screenshot 2023-06-11 at 15 46 52

The below is current report. So my issue was resolved.
Screenshot 2023-06-11 at 15 45 17

@k1LoW
Copy link
Owner

k1LoW commented Jun 11, 2023

The problem is that coverage is not displayed.

Perhaps octocov (or octocov-action) is not getting coverage at this time.
If you are running it through GitHub Actions, you can see that from octocov's output in the Actions log.

One way to debug is to download the coverage data when octocov fails to get coverage and run the octocov command locally.

@k1LoW k1LoW added the help wanted Extra attention is needed label Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants