Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plusLayer has wrong position when using with bottom bar #252

Closed
rbresjer opened this issue Feb 19, 2019 · 3 comments · Fixed by #261
Closed

plusLayer has wrong position when using with bottom bar #252

rbresjer opened this issue Feb 19, 2019 · 3 comments · Fixed by #261

Comments

@rbresjer
Copy link
Contributor

rbresjer commented Feb 19, 2019

Steps to reproduce

  1. Create a UITabBarController with two child UIViewControllers
  2. Add a Floaty with an item to the first child UIVIewControllers
  3. Run the app
  4. Open/expand the Floaty
  5. Switch to the other UIVIewController
  6. Switch back to the UIVIewController with the Floaty

Expected behaviour

The Floaty looks normal, like it looked before you switched tabs.

Actual behaviour

The X-button (plusLayer) is offset incorrectly:

screenshot 2019-02-19 at 16 22 04

Workaround

Close the Floaty on viewWillDisappear, e.g.:

override func viewWillDisappear(_ animated: Bool) {
  floaty.close()
  super.viewWillDisappear(animated)
}
@rbresjer rbresjer changed the title plusLayer has wrong positioning when using with UITabBar plusLayer has wrong position when using with UITabBar Feb 19, 2019
@rbresjer rbresjer changed the title plusLayer has wrong position when using with UITabBar plusLayer has wrong position when using with bottom bar Feb 19, 2019
@weakfl
Copy link
Contributor

weakfl commented Apr 24, 2019

4.1.0 has the same issue, so I don't think this is related to #250.

@RajvinderPayU
Copy link

is it fixed?

@weakfl
Copy link
Contributor

weakfl commented May 28, 2019

is it fixed?

@RajvinderPayU it's fixed in master.

@kciter Maybe you could provide provide a new release including this bugfix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants