Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: defaultAPIBindings are only created as initialization #3248

Open
1 task done
blut opened this issue Jan 15, 2025 · 2 comments
Open
1 task done

feature: defaultAPIBindings are only created as initialization #3248

blut opened this issue Jan 15, 2025 · 2 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@blut
Copy link

blut commented Jan 15, 2025

Feature Description

I'd like the workspace type as a template for different consumers creating a default binding configuration that is kept up to date with the bindings defined in the workspace type.

Proposed Solution

Ideally, newly added defaultAPIBindings should be propagated to any existing workspace of the type (and extensions?)

Alternative Solutions

No response

Want to contribute?

  • I would like to work on this issue.

Additional Context

No response

@blut blut added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2025
@kcp-ci-bot kcp-ci-bot added this to kcp Jan 15, 2025
@github-project-automation github-project-automation bot moved this to New in kcp Jan 15, 2025
@sttts
Copy link
Member

sttts commented Jan 15, 2025

@blut
Copy link
Author

blut commented Jan 16, 2025

So at the moment, defaultAPIBindings are initialized just once, and before enabling any Day-2 operations, here are some considerations to be discussed:

  • Who owns the APIBindings? Similarly, who owns a Workspace?
    • Especially, if WorkspaceTypes are set up hierarchical, how is ownership managed?
    • Do we need to protect APIBindings from unauthorized modifications?

In my mind, a workspace may be managed by a platform team, but any contents are owned by the users of the workspace.
This includes APIBindings within the workspace, irrespective if they are created through the WorkspaceType or by the user directly.

  • How to handle API Binding removal if defaultAPIBindings change in any own the included WorkspaceTypes?
    • Here, I'd suggest if an API Binding is unused, we can remove it.
    • Any used API Binding should be orphaned and remain in a workspace for the workspace owner to manage.

On a solution:

  • If we add lifecycle modes (InitializeOnly vs Reconcile) I'd prefer for the workspace to maintain the mode instead of the WorkspaceType. That way, the creator of the workspace can define the behaviour & operations mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: New
Development

No branches or pull requests

2 participants