Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alteração do arquivo validate_files.py para funcionar com a lib json … #35

Merged
merged 3 commits into from
Jul 12, 2021

Conversation

pedrounes1
Copy link
Contributor

…do python3. Alteração do formato do logger e criação do arquivo de output

…do python3. Alteração do formato do logger e criação do arquivo de output
@pedrounes1
Copy link
Contributor Author

Aproveitei que iria usar os dados e fiz as alterações comentadas na issue #31.

Copy link
Owner

@kelvins kelvins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valeu pela contrib @pedrounes1 🚀

Como esse script roda no Travis CI, seria legal já corrigir ele para fazer o CI passar, por exemplo:

scripts/validate_files.py Outdated Show resolved Hide resolved
scripts/validate_files.py Show resolved Hide resolved
scripts/validate_files.py Outdated Show resolved Hide resolved
@pedrounes1
Copy link
Contributor Author

Gostei das sugestões e fiz as alterações, inclusive no travis.yml

Copy link
Owner

@kelvins kelvins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Booa, valeu @pedrounes1 🎉

@kelvins kelvins merged commit 9409db5 into kelvins:main Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants