Skip to content

Commit 68c817a

Browse files
teiglandswhiteho
authored andcommitted
[DLM] rename dlm_config_info fields
Add a "ci_" prefix to the fields in the dlm_config_info struct so that we can use macros to add configfs functions to access them (in a later patch). No functional changes in this patch, just naming changes. Signed-off-by: David Teigland <[email protected]> Signed-off-by: Steven Whitehouse <[email protected]>
1 parent 8ec6886 commit 68c817a

9 files changed

+38
-37
lines changed

fs/dlm/config.c

+8-8
Original file line numberDiff line numberDiff line change
@@ -777,13 +777,13 @@ int dlm_our_addr(struct sockaddr_storage *addr, int num)
777777
#define DEFAULT_SCAN_SECS 5
778778

779779
struct dlm_config_info dlm_config = {
780-
.tcp_port = DEFAULT_TCP_PORT,
781-
.buffer_size = DEFAULT_BUFFER_SIZE,
782-
.rsbtbl_size = DEFAULT_RSBTBL_SIZE,
783-
.lkbtbl_size = DEFAULT_LKBTBL_SIZE,
784-
.dirtbl_size = DEFAULT_DIRTBL_SIZE,
785-
.recover_timer = DEFAULT_RECOVER_TIMER,
786-
.toss_secs = DEFAULT_TOSS_SECS,
787-
.scan_secs = DEFAULT_SCAN_SECS
780+
.ci_tcp_port = DEFAULT_TCP_PORT,
781+
.ci_buffer_size = DEFAULT_BUFFER_SIZE,
782+
.ci_rsbtbl_size = DEFAULT_RSBTBL_SIZE,
783+
.ci_lkbtbl_size = DEFAULT_LKBTBL_SIZE,
784+
.ci_dirtbl_size = DEFAULT_DIRTBL_SIZE,
785+
.ci_recover_timer = DEFAULT_RECOVER_TIMER,
786+
.ci_toss_secs = DEFAULT_TOSS_SECS,
787+
.ci_scan_secs = DEFAULT_SCAN_SECS
788788
};
789789

fs/dlm/config.h

+8-8
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
#define DLM_MAX_ADDR_COUNT 3
1818

1919
struct dlm_config_info {
20-
int tcp_port;
21-
int buffer_size;
22-
int rsbtbl_size;
23-
int lkbtbl_size;
24-
int dirtbl_size;
25-
int recover_timer;
26-
int toss_secs;
27-
int scan_secs;
20+
int ci_tcp_port;
21+
int ci_buffer_size;
22+
int ci_rsbtbl_size;
23+
int ci_lkbtbl_size;
24+
int ci_dirtbl_size;
25+
int ci_recover_timer;
26+
int ci_toss_secs;
27+
int ci_scan_secs;
2828
};
2929

3030
extern struct dlm_config_info dlm_config;

fs/dlm/lock.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -810,7 +810,7 @@ static int shrink_bucket(struct dlm_ls *ls, int b)
810810
list_for_each_entry_reverse(r, &ls->ls_rsbtbl[b].toss,
811811
res_hashchain) {
812812
if (!time_after_eq(jiffies, r->res_toss_time +
813-
dlm_config.toss_secs * HZ))
813+
dlm_config.ci_toss_secs * HZ))
814814
continue;
815815
found = 1;
816816
break;

fs/dlm/lockspace.c

+5-5
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ static int dlm_scand(void *data)
236236
while (!kthread_should_stop()) {
237237
list_for_each_entry(ls, &lslist, ls_list)
238238
dlm_scan_rsbs(ls);
239-
schedule_timeout_interruptible(dlm_config.scan_secs * HZ);
239+
schedule_timeout_interruptible(dlm_config.ci_scan_secs * HZ);
240240
}
241241
return 0;
242242
}
@@ -422,7 +422,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace,
422422
ls->ls_count = 0;
423423
ls->ls_flags = 0;
424424

425-
size = dlm_config.rsbtbl_size;
425+
size = dlm_config.ci_rsbtbl_size;
426426
ls->ls_rsbtbl_size = size;
427427

428428
ls->ls_rsbtbl = kmalloc(sizeof(struct dlm_rsbtable) * size, GFP_KERNEL);
@@ -434,7 +434,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace,
434434
rwlock_init(&ls->ls_rsbtbl[i].lock);
435435
}
436436

437-
size = dlm_config.lkbtbl_size;
437+
size = dlm_config.ci_lkbtbl_size;
438438
ls->ls_lkbtbl_size = size;
439439

440440
ls->ls_lkbtbl = kmalloc(sizeof(struct dlm_lkbtable) * size, GFP_KERNEL);
@@ -446,7 +446,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace,
446446
ls->ls_lkbtbl[i].counter = 1;
447447
}
448448

449-
size = dlm_config.dirtbl_size;
449+
size = dlm_config.ci_dirtbl_size;
450450
ls->ls_dirtbl_size = size;
451451

452452
ls->ls_dirtbl = kmalloc(sizeof(struct dlm_dirtable) * size, GFP_KERNEL);
@@ -489,7 +489,7 @@ static int new_lockspace(char *name, int namelen, void **lockspace,
489489
mutex_init(&ls->ls_requestqueue_mutex);
490490
mutex_init(&ls->ls_clear_proc_locks);
491491

492-
ls->ls_recover_buf = kmalloc(dlm_config.buffer_size, GFP_KERNEL);
492+
ls->ls_recover_buf = kmalloc(dlm_config.ci_buffer_size, GFP_KERNEL);
493493
if (!ls->ls_recover_buf)
494494
goto out_dirfree;
495495

fs/dlm/lowcomms-sctp.c

+3-3
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ static int add_bind_addr(struct sockaddr_storage *addr, int addr_len, int num)
635635

636636
if (result < 0)
637637
log_print("Can't bind to port %d addr number %d",
638-
dlm_config.tcp_port, num);
638+
dlm_config.ci_tcp_port, num);
639639

640640
return result;
641641
}
@@ -711,7 +711,7 @@ static int init_sock(void)
711711
/* Bind to all interfaces. */
712712
for (i = 0; i < dlm_local_count; i++) {
713713
memcpy(&localaddr, dlm_local_addr[i], sizeof(localaddr));
714-
make_sockaddr(&localaddr, dlm_config.tcp_port, &addr_len);
714+
make_sockaddr(&localaddr, dlm_config.ci_tcp_port, &addr_len);
715715

716716
result = add_bind_addr(&localaddr, addr_len, num);
717717
if (result)
@@ -863,7 +863,7 @@ static void initiate_association(int nodeid)
863863
return;
864864
}
865865

866-
make_sockaddr(&rem_addr, dlm_config.tcp_port, &addrlen);
866+
make_sockaddr(&rem_addr, dlm_config.ci_tcp_port, &addrlen);
867867

868868
outmessage.msg_name = &rem_addr;
869869
outmessage.msg_namelen = addrlen;

fs/dlm/lowcomms-tcp.c

+5-4
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ static void connect_to_sock(struct connection *con)
548548
sock->sk->sk_user_data = con;
549549
con->rx_action = receive_from_sock;
550550

551-
make_sockaddr(&saddr, dlm_config.tcp_port, &addr_len);
551+
make_sockaddr(&saddr, dlm_config.ci_tcp_port, &addr_len);
552552

553553
add_sock(sock, con);
554554

@@ -616,10 +616,10 @@ static struct socket *create_listen_sock(struct connection *con,
616616
con->sock = sock;
617617

618618
/* Bind to our port */
619-
make_sockaddr(saddr, dlm_config.tcp_port, &addr_len);
619+
make_sockaddr(saddr, dlm_config.ci_tcp_port, &addr_len);
620620
result = sock->ops->bind(sock, (struct sockaddr *) saddr, addr_len);
621621
if (result < 0) {
622-
printk("dlm: Can't bind to port %d\n", dlm_config.tcp_port);
622+
printk("dlm: Can't bind to port %d\n", dlm_config.ci_tcp_port);
623623
sock_release(sock);
624624
sock = NULL;
625625
con->sock = NULL;
@@ -638,7 +638,8 @@ static struct socket *create_listen_sock(struct connection *con,
638638

639639
result = sock->ops->listen(sock, 5);
640640
if (result < 0) {
641-
printk("dlm: Can't listen on port %d\n", dlm_config.tcp_port);
641+
printk("dlm: Can't listen on port %d\n",
642+
dlm_config.ci_tcp_port);
642643
sock_release(sock);
643644
sock = NULL;
644645
goto create_out;

fs/dlm/midcomms.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ int dlm_process_incoming_buffer(int nodeid, const void *base,
8282
if (msglen < sizeof(struct dlm_header))
8383
break;
8484
err = -E2BIG;
85-
if (msglen > dlm_config.buffer_size) {
85+
if (msglen > dlm_config.ci_buffer_size) {
8686
log_print("message size %d from %d too big, buf len %d",
8787
msglen, nodeid, len);
8888
break;
@@ -103,7 +103,7 @@ int dlm_process_incoming_buffer(int nodeid, const void *base,
103103

104104
if (msglen > sizeof(__tmp) &&
105105
msg == (struct dlm_header *) __tmp) {
106-
msg = kmalloc(dlm_config.buffer_size, GFP_KERNEL);
106+
msg = kmalloc(dlm_config.ci_buffer_size, GFP_KERNEL);
107107
if (msg == NULL)
108108
return ret;
109109
}

fs/dlm/rcom.c

+4-4
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ int dlm_rcom_status(struct dlm_ls *ls, int nodeid)
138138
goto out;
139139

140140
allow_sync_reply(ls, &rc->rc_id);
141-
memset(ls->ls_recover_buf, 0, dlm_config.buffer_size);
141+
memset(ls->ls_recover_buf, 0, dlm_config.ci_buffer_size);
142142

143143
send_rcom(ls, mh, rc);
144144

@@ -213,7 +213,7 @@ int dlm_rcom_names(struct dlm_ls *ls, int nodeid, char *last_name, int last_len)
213213
if (nodeid == dlm_our_nodeid()) {
214214
dlm_copy_master_names(ls, last_name, last_len,
215215
ls->ls_recover_buf + len,
216-
dlm_config.buffer_size - len, nodeid);
216+
dlm_config.ci_buffer_size - len, nodeid);
217217
goto out;
218218
}
219219

@@ -223,7 +223,7 @@ int dlm_rcom_names(struct dlm_ls *ls, int nodeid, char *last_name, int last_len)
223223
memcpy(rc->rc_buf, last_name, last_len);
224224

225225
allow_sync_reply(ls, &rc->rc_id);
226-
memset(ls->ls_recover_buf, 0, dlm_config.buffer_size);
226+
memset(ls->ls_recover_buf, 0, dlm_config.ci_buffer_size);
227227

228228
send_rcom(ls, mh, rc);
229229

@@ -241,7 +241,7 @@ static void receive_rcom_names(struct dlm_ls *ls, struct dlm_rcom *rc_in)
241241

242242
nodeid = rc_in->rc_header.h_nodeid;
243243
inlen = rc_in->rc_header.h_length - sizeof(struct dlm_rcom);
244-
outlen = dlm_config.buffer_size - sizeof(struct dlm_rcom);
244+
outlen = dlm_config.ci_buffer_size - sizeof(struct dlm_rcom);
245245

246246
error = create_rcom(ls, nodeid, DLM_RCOM_NAMES_REPLY, outlen, &rc, &mh);
247247
if (error)

fs/dlm/recover.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
static void dlm_wait_timer_fn(unsigned long data)
4545
{
4646
struct dlm_ls *ls = (struct dlm_ls *) data;
47-
mod_timer(&ls->ls_timer, jiffies + (dlm_config.recover_timer * HZ));
47+
mod_timer(&ls->ls_timer, jiffies + (dlm_config.ci_recover_timer * HZ));
4848
wake_up(&ls->ls_wait_general);
4949
}
5050

@@ -55,7 +55,7 @@ int dlm_wait_function(struct dlm_ls *ls, int (*testfn) (struct dlm_ls *ls))
5555
init_timer(&ls->ls_timer);
5656
ls->ls_timer.function = dlm_wait_timer_fn;
5757
ls->ls_timer.data = (long) ls;
58-
ls->ls_timer.expires = jiffies + (dlm_config.recover_timer * HZ);
58+
ls->ls_timer.expires = jiffies + (dlm_config.ci_recover_timer * HZ);
5959
add_timer(&ls->ls_timer);
6060

6161
wait_event(ls->ls_wait_general, testfn(ls) || dlm_recovery_stopped(ls));

0 commit comments

Comments
 (0)