Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReaderWidget: cropPercent inverted / crop indicator #151

Open
frankmer opened this issue Jun 28, 2024 · 0 comments
Open

ReaderWidget: cropPercent inverted / crop indicator #151

frankmer opened this issue Jun 28, 2024 · 0 comments

Comments

@frankmer
Copy link
Contributor

frankmer commented Jun 28, 2024

As the title says, cropPercent seems to be inverted. When I set cropPercent to 0.99, the QR code is detected when it fills the entire screen. 0.7 is the right amount to fit the indicator perfectly. 0.5 (the default) is too small. and if i set it smaller, then the qr has to be smaller on the screen. But I understand cropPercent as how much is cropped, not how much is left after cropping.

And because it affects the same variable:
As I said, 0.5 (the default) is too small. Please set the default to 0.7 (when not changing cropPercent inversion) or 0.3 (when changing cropPercent inversion).

Bonus:
It would be verry nice if the indicator is automatically (or only when a new bool variable for it is set to true) ajustest by the cropPercent so it will always match. Otherwise it will confuse the user if the QR has to be smaller than the indicator to scan the QR code.

Update:
The default is just too small on my iPhone, on my Android device it is perfect. But if I set it to 0.7, the indicator is too small on the Android. But still better than the indicator being too big. This makes it even more important to make the indicator match the actual crop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant