From 52a0a9a371c0e10a3a23a8e6e641978b522e1c1e Mon Sep 17 00:00:00 2001 From: Joe Schr Date: Mon, 15 Feb 2021 11:37:17 +0100 Subject: [PATCH] Remove `aroon` in favor of ta.AROON --- README.md | 3 +-- technical/indicators/momentum.py | 10 ---------- tests/test_indicators.py | 12 ------------ 3 files changed, 1 insertion(+), 24 deletions(-) diff --git a/README.md b/README.md index 667118cf..94a1a57a 100644 --- a/README.md +++ b/README.md @@ -41,7 +41,6 @@ The following indicators are available and have been 'wrapped' to be used on a d * [chaikin_money_flow](https://www.tradingview.com/wiki/Chaikin_Money_Flow_(CMF)) - Chaikin Money Flow, requires dataframe and period * [accumulation_distribution](https://www.investopedia.com/terms/a/accumulationdistribution.asp) - requires a dataframe * osc - requires a dataframe and the periods -* [aroon](https://www.investopedia.com/terms/a/aroon.asp) - dataframe, period, field * [atr](https://www.investopedia.com/terms/a/atr.asp) - dataframe, period, field * [atr_percent](https://www.investopedia.com/terms/a/atr.asp) - dataframe, period, field * [bollinger_bands](https://www.investopedia.com/terms/b/bollingerbands.asp) - dataframe, period, stdv, field, prefix @@ -85,7 +84,7 @@ dataframe_long['rsi'] = ta.RSI(dataframe_long) dataframe = resampled_merge(dataframe, dataframe_long, fill_na=True) """ -The resulting dataframe will have 5 resampled columns in addition to the regular columns, +The resulting dataframe will have 5 resampled columns in addition to the regular columns, following the template resample__. So in the above example: ['resample_240_open', 'resample_240_high', 'resample_240_low','resample_240_close', 'resample_240_rsi'] diff --git a/technical/indicators/momentum.py b/technical/indicators/momentum.py index 8cef5b99..8fa666d1 100644 --- a/technical/indicators/momentum.py +++ b/technical/indicators/momentum.py @@ -15,16 +15,6 @@ # ADXR Average Directional Movement Index Rating # APO Absolute Price Oscillator -# AROON Aroon -def aroon(dataframe, period=25, field='close', colum_prefix="aroon") -> DataFrame: - from pyti.aroon import aroon_up as up - from pyti.aroon import aroon_down as down - dataframe["{}_up".format(colum_prefix)] = up(dataframe[field], period) - dataframe["{}_down".format(colum_prefix)] = down(dataframe[field], period) - return dataframe - - -# AROONOSC Aroon Oscillator # BOP Balance Of Power # CCI Commodity Channel Index diff --git a/tests/test_indicators.py b/tests/test_indicators.py index c90e0e29..76ee067d 100644 --- a/tests/test_indicators.py +++ b/tests/test_indicators.py @@ -2,18 +2,6 @@ import pytest -@pytest.mark.skip(reason="this fails right now") -def test_arron(testdata_1m_btc): - from technical.indicators import aroon - - print() - print(testdata_1m_btc) - - result = aroon(testdata_1m_btc) - - print(result) - - def test_atr(testdata_1m_btc): from technical.indicators import atr