Skip to content
This repository has been archived by the owner on Jan 9, 2025. It is now read-only.

bug: remove modexp #1422

Closed
enitrat opened this issue Sep 18, 2024 · 2 comments · Fixed by #1429
Closed

bug: remove modexp #1422

enitrat opened this issue Sep 18, 2024 · 2 comments · Fixed by #1429

Comments

@enitrat
Copy link
Collaborator

enitrat commented Sep 18, 2024

Modexp, which is delegated to a Cairo1 class, doesn't work for all types of inputs.

As such, I suggest removing it from the precompiles enabled and add info about it in the docs.

We can focus on developping a smaller-scoped version that goes up to 2^256 inputs.
@github-project-automation github-project-automation bot moved this to 🆕 Backlog in Kakarot on Starknet Sep 18, 2024
@ShantelPeters

This comment was marked as abuse.

Sign in to view
@onlydustapp OnlyDustApp
Copy link

onlydustapp bot commented Sep 18, 2024

Hey @ShantelPeters!
Thanks for showing interest.
We've created an application for you to contribute to Kakarot zkEVM.
Go check it out on OnlyDust!

@enitrat enitrat mentioned this issue Sep 20, 2024
Merged
7 tasks
enitrat added a commit that referenced this issue Sep 20, 2024
@enitrat
feat: disable modexp (#1429)
c7896d0 
<!--- Please provide a general summary of your changes in the title
above -->

<!-- Give an estimate of the time you spent on this PR in terms of work
days.
Did you spend 0.5 days on this PR or rather 2 days?  -->

Time spent on this PR:

## Pull request type

<!-- Please try to limit your pull request to one type,
submit multiple pull requests if needed. -->

Please check the type of change your PR introduces:

- [ ] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, renaming)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] Documentation content changes
- [ ] Other (please describe):

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying,
or link to a relevant issue. -->

Resolves #1422

## What is the new behavior?

<!-- Please describe the behavior or changes that are being added by
this PR. -->

- Disables the external call to the cairo1 class for modexp operations
- Removes the legacy modexp files.
-

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg"
height="34" align="absmiddle"
alt="Reviewable"/>](https://reviewable.io/reviews/kkrt-labs/kakarot/1429)
<!-- Reviewable:end -->
@github-project-automation github-project-automation bot moved this from 🆕 Backlog to ✅ Done in Kakarot on Starknet Sep 20, 2024
matthieuauger pushed a commit to matthieuauger/kakarot that referenced this issue Nov 9, 2024
@tcoratger
bump katana to v1.0.0-alpha.13 (kkrt-labs#1422)
042525b 
* bump katana to v1.0.0-alpha.13

* maj submodule
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Kakarot on Starknet
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: disable modexp kkrt-labs/kakarot
2 participants
@enitrat @ShantelPeters