From a7690a023ceba34893ac2e100f71b7380dd77532 Mon Sep 17 00:00:00 2001 From: Dan Halperin <dhalperi@google.com> Date: Mon, 13 Jun 2016 17:34:58 -0700 Subject: [PATCH] CompressedSourceTest: simplify We should use random.nextBytes(buff) instead of making the array in a loop. The code we now point to is the same as the for loop, so the test continues to pass. --- .../google/cloud/dataflow/sdk/io/CompressedSourceTest.java | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sdk/src/test/java/com/google/cloud/dataflow/sdk/io/CompressedSourceTest.java b/sdk/src/test/java/com/google/cloud/dataflow/sdk/io/CompressedSourceTest.java index 702d93cba5..e6769315fc 100644 --- a/sdk/src/test/java/com/google/cloud/dataflow/sdk/io/CompressedSourceTest.java +++ b/sdk/src/test/java/com/google/cloud/dataflow/sdk/io/CompressedSourceTest.java @@ -368,9 +368,7 @@ private byte[] generateInput(int size) { // Arbitrary but fixed seed Random random = new Random(285930); byte[] buff = new byte[size]; - for (int i = 0; i < size; i++) { - buff[i] = (byte) (random.nextInt() % Byte.MAX_VALUE); - } + random.nextBytes(buff); return buff; }