Skip to content

Commit 7bb0706

Browse files
aminamosetagwerker
authored andcommitted
update from PR rails#36222
1 parent a974898 commit 7bb0706

File tree

33 files changed

+43
-43
lines changed

33 files changed

+43
-43
lines changed

actioncable/app/javascript/action_cable/consumer.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Subscriptions from "./subscriptions"
66
// The Consumer instance is also the gateway to establishing subscriptions to desired channels through the #createSubscription
77
// method.
88
//
9-
// The following example shows how this can be setup:
9+
// The following example shows how this can be set up:
1010
//
1111
// App = {}
1212
// App.cable = ActionCable.createConsumer("ws://example.com/accounts/1")

actioncable/lib/action_cable/channel/base.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ def unsubscribe_from_channel # :nodoc:
194194
end
195195

196196
private
197-
# Called once a consumer has become a subscriber of the channel. Usually the place to setup any streams
197+
# Called once a consumer has become a subscriber of the channel. Usually the place to set up any streams
198198
# you want this channel to be sending to the subscriber.
199199
def subscribed # :doc:
200200
# Override in subclasses

actioncable/lib/action_cable/channel/test_case.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ def determine_default_channel(name)
209209
end
210210
end
211211

212-
# Setup test connection with the specified identifiers:
212+
# Set up test connection with the specified identifiers:
213213
#
214214
# class ApplicationCable < ActionCable::Connection::Base
215215
# identified_by :user, :token

actioncable/lib/action_cable/connection/test_case.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def initialize(request)
101101
# assert_equal "1", connection.user.id
102102
# end
103103
#
104-
# You can also setup the correct cookies before the connection request:
104+
# You can also set up the correct cookies before the connection request:
105105
#
106106
# def test_connect_with_cookies
107107
# # Plain cookies:

actioncable/lib/action_cable/server/base.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def initialize(config: self.class.config)
2727
@remote_connections = @event_loop = @worker_pool = @pubsub = nil
2828
end
2929

30-
# Called by Rack to setup the server.
30+
# Called by Rack to set up the server.
3131
def call(env)
3232
setup_heartbeat_timer
3333
config.connection_class.call.new(self, env).process

actioncable/test/connection/base_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def send_async(method, *args)
7676
connection = open_connection
7777
connection.process
7878

79-
# Setup the connection
79+
# Set up the connection
8080
connection.send :handle_open
8181
assert connection.connected
8282

actionmailbox/test/dummy/bin/setup

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ def system!(*args)
1010
end
1111

1212
chdir APP_ROOT do
13-
# This script is a starting point to setup your application.
14-
# Add necessary setup steps to this file.
13+
# This script is a starting point to set up your application.
14+
# Add necessary set up steps to this file.
1515

1616
puts '== Installing dependencies =='
1717
system! 'gem install bundler --conservative'

actionmailer/lib/action_mailer/base.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ module ActionMailer
2020
#
2121
# The generated model inherits from <tt>ApplicationMailer</tt> which in turn
2222
# inherits from <tt>ActionMailer::Base</tt>. A mailer model defines methods
23-
# used to generate an email message. In these methods, you can setup variables to be used in
23+
# used to generate an email message. In these methods, you can set up variables to be used in
2424
# the mailer views, options on the mail itself such as the <tt>:from</tt> address, and attachments.
2525
#
2626
# class ApplicationMailer < ActionMailer::Base
@@ -873,7 +873,7 @@ def mail(headers = {}, &block)
873873

874874
create_parts_from_responses(message, responses)
875875

876-
# Setup content type, reapply charset and handle parts order
876+
# Set up content type, reapply charset and handle parts order
877877
message.content_type = set_content_type(message, content_type, headers[:content_type])
878878
message.charset = charset
879879

actiontext/test/dummy/bin/setup

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ def system!(*args)
1010
end
1111

1212
chdir APP_ROOT do
13-
# This script is a starting point to setup your application.
14-
# Add necessary setup steps to this file.
13+
# This script is a starting point to set up your application.
14+
# Add necessary set up steps to this file.
1515

1616
puts '== Installing dependencies =='
1717
system! 'gem install bundler --conservative'

actionview/app/assets/javascripts/rails-ujs/utils/ajax.coffee

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ prepareOptions = (options) ->
4545

4646
createXHR = (options, done) ->
4747
xhr = new XMLHttpRequest()
48-
# Open and setup xhr
48+
# Open and set up xhr
4949
xhr.open(options.type, options.url, true)
5050
xhr.setRequestHeader('Accept', options.accept)
5151
# Set Content-Type only when sending a string

actionview/lib/action_view/base.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ module ActionView #:nodoc:
2727
# Name: <%= person.name %><br/>
2828
# <% end %>
2929
#
30-
# The loop is setup in regular embedding tags <tt><% %></tt>, and the name is written using the output embedding tag <tt><%= %></tt>. Note that this
30+
# The loop is set up in regular embedding tags <tt><% %></tt>, and the name is written using the output embedding tag <tt><%= %></tt>. Note that this
3131
# is not just a usage suggestion. Regular output functions like print or puts won't work with ERB templates. So this would be wrong:
3232
#
3333
# <%# WRONG %>

actionview/lib/action_view/helpers/asset_url_helper.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ module Helpers #:nodoc:
5252
# solution being slower. You should be sure to measure your actual
5353
# performance across targeted browsers both before and after this change.
5454
#
55-
# To implement the corresponding hosts you can either setup four actual
55+
# To implement the corresponding hosts you can either set up four actual
5656
# hosts or use wildcard DNS to CNAME the wildcard to a single asset host.
5757
# You can read more about setting up your DNS CNAME records from your ISP.
5858
#

actionview/lib/action_view/renderer/abstract_renderer.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ module ActionView
1414
#
1515
# Whenever the +render+ method is called on the base +Renderer+ class, a new
1616
# renderer object of the correct type is created, and the +render+ method on
17-
# that new object is called in turn. This abstracts the setup and rendering
17+
# that new object is called in turn. This abstracts the set up and rendering
1818
# into a separate classes for partials and templates.
1919
class AbstractRenderer #:nodoc:
2020
delegate :template_exists?, :any_templates?, :formats, to: :@lookup_context

actionview/lib/action_view/renderer/partial_renderer.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ def render_partial(view, template)
370370
#
371371
# If +options[:partial]+ is a string, then the <tt>@path</tt> instance variable is
372372
# set to that string. Otherwise, the +options[:partial]+ object must
373-
# respond to +to_partial_path+ in order to setup the path.
373+
# respond to +to_partial_path+ in order to set up the path.
374374
def setup(context, options, as, block)
375375
@options = options
376376
@block = block

actionview/lib/action_view/rendering.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ def initialize
3333
super
3434
end
3535

36-
# Overwrite process to setup I18n proxy.
36+
# Overwrite process to set up I18n proxy.
3737
def process(*) #:nodoc:
3838
old_config, I18n.config = I18n.config, I18nProxy.new(I18n.config, lookup_context)
3939
super

actionview/test/ujs/public/test/data-remote.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ module('data-remote', {
4747
asyncTest('ctrl-clicking on a link does not fire ajaxyness', 0, function() {
4848
var link = $('a[data-remote]')
4949

50-
// Ideally, we'd setup an iframe to intercept normal link clicks
50+
// Ideally, we'd set up an iframe to intercept normal link clicks
5151
// and add a test to make sure the iframe:loaded event is triggered.
5252
// However, jquery doesn't actually cause a native `click` event and
5353
// follow links using `trigger('click')`, it only fires bindings.
@@ -66,7 +66,7 @@ asyncTest('ctrl-clicking on a link does not fire ajaxyness', 0, function() {
6666
asyncTest('right/mouse-wheel-clicking on a link does not fire ajaxyness', 0, function() {
6767
var link = $('a[data-remote]')
6868

69-
// Ideally, we'd setup an iframe to intercept normal link clicks
69+
// Ideally, we'd set up an iframe to intercept normal link clicks
7070
// and add a test to make sure the iframe:loaded event is triggered.
7171
// However, jquery doesn't actually cause a native `click` event and
7272
// follow links using `trigger('click')`, it only fires bindings.
@@ -184,7 +184,7 @@ asyncTest('clicking on a button with data-remote attribute', 5, function() {
184184
asyncTest('right/mouse-wheel-clicking on a button with data-remote attribute does not fire ajaxyness', 0, function() {
185185
var button = $('button[data-remote]')
186186

187-
// Ideally, we'd setup an iframe to intercept normal link clicks
187+
// Ideally, we'd set up an iframe to intercept normal link clicks
188188
// and add a test to make sure the iframe:loaded event is triggered.
189189
// However, jquery doesn't actually cause a native `click` event and
190190
// follow links using `trigger('click')`, it only fires bindings.

activemodel/lib/active_model/validator.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ module ActiveModel
8585
#
8686
# It can be useful to access the class that is using that validator when there are prerequisites such
8787
# as an +attr_accessor+ being present. This class is accessible via <tt>options[:class]</tt> in the constructor.
88-
# To setup your validator override the constructor.
88+
# To set up your validator override the constructor.
8989
#
9090
# class MyValidator < ActiveModel::Validator
9191
# def initialize(options={})

activerecord/examples/performance.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ def self.email
7070

7171
# pre-compute the insert statements and fake data compilation,
7272
# so the benchmarks below show the actual runtime for the execute
73-
# method, minus the setup steps
73+
# method, minus the set up steps
7474

7575
# Using the same paragraph for all exhibits because it is very slow
7676
# to generate unique paragraphs for all exhibits.

activerecord/lib/active_record/fixtures.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ class FixtureClassNotFound < ActiveRecord::ActiveRecordError #:nodoc:
192192
# When *not* to use transactional tests:
193193
#
194194
# 1. You're testing whether a transaction works correctly. Nested transactions don't commit until
195-
# all parent transactions commit, particularly, the fixtures transaction which is begun in setup
195+
# all parent transactions commit, particularly, the fixtures transaction which is begun in set up
196196
# and rolled back in teardown. Thus, you won't be able to verify
197197
# the results of your transaction until Active Record supports nested transactions or savepoints (in progress).
198198
# 2. Your database does not support transactions. Every Active Record database supports transactions except MySQL MyISAM.

guides/source/5_1_release_notes.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ screenshots.
8989
Rails now allows management of application secrets in a secure way,
9090
inspired by the [sekrets](https://github.com/ahoward/sekrets) gem.
9191

92-
Run `bin/rails secrets:setup` to setup a new encrypted secrets file. This will
92+
Run `bin/rails secrets:setup` to set up a new encrypted secrets file. This will
9393
also generate a master key, which must be stored outside of the repository. The
9494
secrets themselves can then be safely checked into the revision control system,
9595
in an encrypted form.

guides/source/action_cable_overview.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ incorporate real-time features into your Rails application.
99
After reading this guide, you will know:
1010

1111
* What Action Cable is and its integration backend and frontend
12-
* How to setup Action Cable
13-
* How to setup channels
12+
* How to set up Action Cable
13+
* How to set up channels
1414
* Deployment and Architecture setup for running Action Cable
1515

1616
--------------------------------------------------------------------------------
@@ -627,7 +627,7 @@ and unpacked for the data argument arriving as `received`.
627627
### More Complete Examples
628628
629629
See the [rails/actioncable-examples](https://github.com/rails/actioncable-examples)
630-
repository for a full example of how to setup Action Cable in a Rails app and adding channels.
630+
repository for a full example of how to set up Action Cable in a Rails app and adding channels.
631631
632632
## Configuration
633633

guides/source/active_record_multiple_databases.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ This guide covers using multiple databases with your Rails application.
77

88
After reading this guide you will know:
99

10-
* How to setup your application for multiple databases.
10+
* How to set up your application for multiple databases.
1111
* How automatic connection switching works.
1212
* What features are supported and what's still a work in progress.
1313

guides/source/active_record_postgresql.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ installed. Older versions are not supported.
1919

2020
To get started with PostgreSQL have a look at the
2121
[configuring Rails guide](configuring.html#configuring-a-postgresql-database).
22-
It describes how to properly setup Active Record for PostgreSQL.
22+
It describes how to properly set up Active Record for PostgreSQL.
2323

2424
Datatypes
2525
---------

guides/source/contributing_to_ruby_on_rails.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ Contributing to the Rails Code
187187

188188
### Setting Up a Development Environment
189189

190-
To move on from submitting bugs to helping resolve existing issues or contributing your own code to Ruby on Rails, you _must_ be able to run its test suite. In this section of the guide, you'll learn how to setup the tests on your own computer.
190+
To move on from submitting bugs to helping resolve existing issues or contributing your own code to Ruby on Rails, you _must_ be able to run its test suite. In this section of the guide, you'll learn how to set up the tests on your own computer.
191191

192192
#### The Easy Way
193193

@@ -291,7 +291,7 @@ scenarios. Ideally, they should be based on real-world scenarios extracted
291291
from production applications.
292292

293293
You can use the [benchmark template](https://github.com/rails/rails/blob/master/guides/bug_report_templates/benchmark.rb)
294-
as a starting point. It includes the boilerplate code to setup a benchmark
294+
as a starting point. It includes the boilerplate code to set up a benchmark
295295
using the [benchmark-ips](https://github.com/evanphx/benchmark-ips) gem. The
296296
template is designed for testing relatively self-contained changes that can be
297297
inlined into the script.

guides/source/development_dependencies_install.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
Development Dependencies Install
44
================================
55

6-
This guide covers how to setup an environment for Ruby on Rails core development.
6+
This guide covers how to set up an environment for Ruby on Rails core development.
77

88
After reading this guide, you will know:
99

@@ -168,7 +168,7 @@ mysql> GRANT ALL PRIVILEGES ON inexistent_activerecord_unittest.*
168168
to 'rails'@'localhost';
169169
```
170170

171-
PostgreSQL's authentication works differently. To setup the development environment
171+
PostgreSQL's authentication works differently. To set up the development environment
172172
with your development account, on Linux or BSD, you just have to run:
173173

174174
```bash
@@ -242,4 +242,4 @@ if you don't need to run Active Record tests.
242242

243243
### Contribute to Rails
244244

245-
After you've setup everything, read how you can start [contributing](contributing_to_ruby_on_rails.html#running-an-application-against-your-local-branch).
245+
After you've set up everything, read how you can start [contributing](contributing_to_ruby_on_rails.html#running-an-application-against-your-local-branch).

guides/source/getting_started.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ of the files and folders that Rails created by default:
168168
| File/Folder | Purpose |
169169
| ----------- | ------- |
170170
|app/|Contains the controllers, models, views, helpers, mailers, channels, jobs, and assets for your application. You'll focus on this folder for the remainder of this guide.|
171-
|bin/|Contains the rails script that starts your app and can contain other scripts you use to setup, update, deploy, or run your application.|
171+
|bin/|Contains the rails script that starts your app and can contain other scripts you use to set up, update, deploy, or run your application.|
172172
|config/|Configure your application's routes, database, and more. This is covered in more detail in [Configuring Rails Applications](configuring.html).|
173173
|config.ru|Rack configuration for Rack based servers used to start the application. For more information about Rack, see the [Rack website](https://rack.github.io/).|
174174
|db/|Contains your current database schema, as well as the database migrations.|

guides/source/security.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ rotation.
151151
Once users with SHA1 digested signed cookies should no longer have a chance to
152152
have their cookies rewritten, remove the rotation.
153153
154-
While you can setup as many rotations as you'd like it's not common to have many
154+
While you can set up as many rotations as you'd like it's not common to have many
155155
rotations going at any one time.
156156
157157
For more details on key rotation with encrypted and signed messages as

railties/lib/rails/application.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ module Rails
4646
# process. From the moment you require "config/application.rb" in your app,
4747
# the booting process goes like this:
4848
#
49-
# 1) require "config/boot.rb" to setup load paths
49+
# 1) require "config/boot.rb" to set up load paths
5050
# 2) require railties and engines
5151
# 3) Define Rails.application as "class MyApp::Application < Rails::Application"
5252
# 4) Run config.before_configuration callbacks

railties/lib/rails/generators/rails/app/templates/bin/setup.tt

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ def system!(*args)
88
end
99

1010
FileUtils.chdir APP_ROOT do
11-
# This script is a way to setup or update your development environment automatically.
11+
# This script is a way to set up or update your development environment automatically.
1212
# This script is idempotent, so that you can run it at anytime and get an expectable outcome.
1313
# Add necessary setup steps to this file.
1414

railties/lib/rails/generators/test_case.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ module Generators
1111
# Disable color in output. Easier to debug.
1212
no_color!
1313

14-
# This class provides a TestCase for testing generators. To setup, you need
14+
# This class provides a TestCase for testing generators. To set up, you need
1515
# just to configure the destination and set which generator is being tested:
1616
#
1717
# class AppGeneratorTest < Rails::Generators::TestCase

railties/test/generators/app_generator_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ class AppGeneratorTest < Rails::Generators::TestCase
9898
include GeneratorsTestHelper
9999
arguments [destination_root]
100100

101-
# brings setup, teardown, and some tests
101+
# brings set up, teardown, and some tests
102102
include SharedGeneratorTests
103103

104104
def default_files

railties/test/generators/plugin_generator_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def application_path
3030
"#{destination_root}/test/dummy"
3131
end
3232

33-
# brings setup, teardown, and some tests
33+
# brings set up, teardown, and some tests
3434
include SharedGeneratorTests
3535

3636
def test_invalid_plugin_name_raises_an_error

railties/test/generators/shared_generator_tests.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# frozen_string_literal: true
22

33
#
4-
# Tests, setup, and teardown common to the application and plugin generator suites.
4+
# Tests, set up, and teardown common to the application and plugin generator suites.
55
#
66
module SharedGeneratorTests
77
def setup

0 commit comments

Comments
 (0)