class Foo < Struct.new(:x) creates an extra unneeded anonymous class

because Struct.new returns a Class, we just can give it a name and use it directly without inheriting from it

Author: amatsuda

actionpack/lib/action_controller/metal/params_wrapper.rb

@@ -73,7 +73,7 @@ module ParamsWrapper
 
     require "mutex_m"
 
-    class Options < Struct.new(:name, :format, :include, :exclude, :klass, :model) # :nodoc:
+    Options = Struct.new(:name, :format, :include, :exclude, :klass, :model) do # :nodoc:
       include Mutex_m
 
       def self.from_hash(hash)

actionpack/lib/action_dispatch/journey/visitors.rb

@@ -5,7 +5,7 @@ class Format
       ESCAPE_PATH    = ->(value) { Router::Utils.escape_path(value) }
       ESCAPE_SEGMENT = ->(value) { Router::Utils.escape_segment(value) }
 
-      class Parameter < Struct.new(:name, :escaper)
+      Parameter = Struct.new(:name, :escaper) do
         def escape(value); escaper.call value; end
       end
 

actionpack/test/lib/controller/fake_models.rb

@@ -1,6 +1,6 @@
 require "active_model"
 
-class Customer < Struct.new(:name, :id)
+Customer = Struct.new(:name, :id) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
 
@@ -28,7 +28,7 @@ def persisted?
   end
 end
 
-class Post < Struct.new(:title, :author_name, :body, :secret, :persisted, :written_on, :cost)
+Post = Struct.new(:title, :author_name, :body, :secret, :persisted, :written_on, :cost) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
   extend ActiveModel::Translation

actionview/test/actionpack/controller/render_test.rb

@@ -5,7 +5,7 @@ class ApplicationController < ActionController::Base
   self.view_paths = File.join(FIXTURE_LOAD_PATH, "actionpack")
 end
 
-class Customer < Struct.new(:name, :id)
+Customer = Struct.new(:name, :id) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
 
@@ -39,7 +39,7 @@ def cache_key
 
 module Quiz
   #Models
-  class Question < Struct.new(:name, :id)
+  Question = Struct.new(:name, :id) do
     extend ActiveModel::Naming
     include ActiveModel::Conversion
 

actionview/test/activerecord/render_partial_with_record_identification_test.rb

@@ -87,7 +87,7 @@ def test_rendering_partial_with_has_one_association
   end
 end
 
-class Game < Struct.new(:name, :id)
+Game = Struct.new(:name, :id) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
   def to_param

actionview/test/lib/controller/fake_models.rb

@@ -1,6 +1,6 @@
 require "active_model"
 
-class Customer < Struct.new(:name, :id)
+Customer = Struct.new(:name, :id) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
 
@@ -31,7 +31,7 @@ def persisted?
 class GoodCustomer < Customer
 end
 
-class Post < Struct.new(:title, :author_name, :body, :secret, :persisted, :written_on, :cost)
+Post = Struct.new(:title, :author_name, :body, :secret, :persisted, :written_on, :cost) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
   extend ActiveModel::Translation
@@ -163,7 +163,7 @@ def self.use_relative_model_naming?
     true
   end
 
-  class Post < Struct.new(:title, :id)
+  Post = Struct.new(:title, :id) do
     extend ActiveModel::Naming
     include ActiveModel::Conversion
 
@@ -183,8 +183,7 @@ def each
   end
 end
 
-class Car < Struct.new(:color)
-end
+Car = Struct.new(:color)
 
 class Plane
   attr_reader :to_key

actionview/test/template/active_model_helper_test.rb

@@ -4,7 +4,7 @@ class ActiveModelHelperTest < ActionView::TestCase
   tests ActionView::Helpers::ActiveModelHelper
 
   silence_warnings do
-    class Post < Struct.new(:author_name, :body, :updated_at)
+    Post = Struct.new(:author_name, :body, :updated_at) do
       include ActiveModel::Conversion
       include ActiveModel::Validations
 

actionview/test/template/atom_feed_helper_test.rb

@@ -1,6 +1,6 @@
 require "abstract_unit"
 
-class Scroll < Struct.new(:id, :to_param, :title, :body, :updated_at, :created_at)
+Scroll = Struct.new(:id, :to_param, :title, :body, :updated_at, :created_at) do
   extend ActiveModel::Naming
   include ActiveModel::Conversion
 

actionview/test/template/form_collections_helper_test.rb

@@ -1,7 +1,6 @@
 require "abstract_unit"
 
-class Category < Struct.new(:id, :name)
-end
+Category = Struct.new(:id, :name)
 
 class FormCollectionsHelperTest < ActionView::TestCase
   def assert_no_select(selector, value = nil)

activerecord/lib/active_record/associations/join_dependency.rb

@@ -32,7 +32,7 @@ def column_alias(node, column)
           @alias_cache[node][column]
         end
 
-        class Table < Struct.new(:node, :columns) # :nodoc:
+        Table = Struct.new(:node, :columns) do # :nodoc:
           def table
             Arel::Nodes::TableAlias.new node.table, node.aliased_table_name
           end

activerecord/lib/active_record/connection_adapters/abstract/schema_definitions.rb

@@ -3,29 +3,25 @@ module ConnectionAdapters #:nodoc:
     # Abstract representation of an index definition on a table. Instances of
     # this type are typically created and returned by methods in database
     # adapters. e.g. ActiveRecord::ConnectionAdapters::AbstractMysqlAdapter#indexes
-    class IndexDefinition < Struct.new(:table, :name, :unique, :columns, :lengths, :orders, :where, :type, :using, :comment) #:nodoc:
-    end
+    IndexDefinition = Struct.new(:table, :name, :unique, :columns, :lengths, :orders, :where, :type, :using, :comment) #:nodoc:
 
     # Abstract representation of a column definition. Instances of this type
     # are typically created by methods in TableDefinition, and added to the
     # +columns+ attribute of said TableDefinition object, in order to be used
     # for generating a number of table creation or table changing SQL statements.
-    class ColumnDefinition < Struct.new(:name, :type, :limit, :precision, :scale, :default, :null, :first, :after, :auto_increment, :primary_key, :collation, :sql_type, :comment) #:nodoc:
+    ColumnDefinition = Struct.new(:name, :type, :limit, :precision, :scale, :default, :null, :first, :after, :auto_increment, :primary_key, :collation, :sql_type, :comment) do #:nodoc:
       def primary_key?
         primary_key || type.to_sym == :primary_key
       end
     end
 
-    class AddColumnDefinition < Struct.new(:column) # :nodoc:
-    end
+    AddColumnDefinition = Struct.new(:column) # :nodoc:
 
-    class ChangeColumnDefinition < Struct.new(:column, :name) #:nodoc:
-    end
+    ChangeColumnDefinition = Struct.new(:column, :name) #:nodoc:
 
-    class PrimaryKeyDefinition < Struct.new(:name) # :nodoc:
-    end
+    PrimaryKeyDefinition = Struct.new(:name) # :nodoc:
 
-    class ForeignKeyDefinition < Struct.new(:from_table, :to_table, :options) #:nodoc:
+    ForeignKeyDefinition = Struct.new(:from_table, :to_table, :options) do #:nodoc:
       def name
         options[:name]
       end

activerecord/lib/active_record/migration.rb

@@ -692,7 +692,7 @@ def reverting?
       connection.respond_to?(:reverting) && connection.reverting
     end
 
-    class ReversibleBlockHelper < Struct.new(:reverting) # :nodoc:
+    ReversibleBlockHelper = Struct.new(:reverting) do # :nodoc:
       def up
         yield unless reverting
       end
@@ -938,7 +938,7 @@ def execute_block
 
   # MigrationProxy is used to defer loading of the actual migration classes
   # until they are needed
-  class MigrationProxy < Struct.new(:name, :version, :filename, :scope)
+  MigrationProxy = Struct.new(:name, :version, :filename, :scope) do
     def initialize(name, version, filename, scope)
       super
       @migration = nil

activerecord/test/cases/attribute_methods/read_test.rb

@@ -3,7 +3,7 @@
 module ActiveRecord
   module AttributeMethods
     class ReadTest < ActiveRecord::TestCase
-      class FakeColumn < Struct.new(:name)
+      FakeColumn = Struct.new(:name) do
         def type; :integer; end
       end
 

activerecord/test/cases/relation/mutation_test.rb

@@ -3,7 +3,7 @@
 
 module ActiveRecord
   class RelationMutationTest < ActiveRecord::TestCase
-    class FakeKlass < Struct.new(:table_name, :name)
+    FakeKlass = Struct.new(:table_name, :name) do
       extend ActiveRecord::Delegation::DelegateCache
       inherited self
 

activerecord/test/cases/relation_test.rb

@@ -8,7 +8,7 @@ module ActiveRecord
   class RelationTest < ActiveRecord::TestCase
     fixtures :posts, :comments, :authors
 
-    class FakeKlass < Struct.new(:table_name, :name)
+    FakeKlass = Struct.new(:table_name, :name) do
       extend ActiveRecord::Delegation::DelegateCache
 
       inherited self

activesupport/lib/active_support/execution_wrapper.rb

@@ -19,14 +19,14 @@ def self.to_complete(*args, &block)
       set_callback(:complete, *args, &block)
     end
 
-    class RunHook < Struct.new(:hook) # :nodoc:
+    RunHook = Struct.new(:hook) do # :nodoc:
       def before(target)
         hook_state = target.send(:hook_state)
         hook_state[hook] = hook.run
       end
     end
 
-    class CompleteHook < Struct.new(:hook) # :nodoc:
+    CompleteHook = Struct.new(:hook) do # :nodoc:
       def before(target)
         hook_state = target.send(:hook_state)
         if hook_state.key?(hook)

activesupport/test/core_ext/module_test.rb

@@ -24,7 +24,7 @@ class Cd
   attr_accessor :name
 end
 
-class Someone < Struct.new(:name, :place)
+Someone = Struct.new(:name, :place) do
   delegate :street, :city, :to_f, to: :place
   delegate :name=, to: :place, prefix: true
   delegate :upcase, to: "place.city"

activesupport/test/json/encoding_test_cases.rb

@@ -23,7 +23,7 @@ def as_json(options = nil)
     end
   end
 
-  class MyStruct < Struct.new(:name, :value)
+  MyStruct = Struct.new(:name, :value) do
     def initialize(*)
       @unused = "unused instance variable"
       super

railties/lib/rails/generators/app_base.rb

@@ -209,7 +209,7 @@ def sqlite3? # :doc:
         !options[:skip_active_record] && options[:database] == "sqlite3"
       end
 
-      class GemfileEntry < Struct.new(:name, :version, :comment, :options, :commented_out)
+      GemfileEntry = Struct.new(:name, :version, :comment, :options, :commented_out) do
         def initialize(name, version, comment, options = {}, commented_out = false)
           super
         end

railties/lib/rails/source_annotation_extractor.rb

@@ -13,7 +13,7 @@
 # start with the tag optionally followed by a colon. Everything up to the end
 # of the line (or closing ERB comment tag) is considered to be their text.
 class SourceAnnotationExtractor
-  class Annotation < Struct.new(:line, :tag, :text)
+  Annotation = Struct.new(:line, :tag, :text) do
     def self.directories
       @@directories ||= %w(app config db lib test) + (ENV["SOURCE_ANNOTATION_DIRECTORIES"] || "").split(",")
     end

railties/test/rack_logger_test.rb

@@ -20,7 +20,7 @@ def initialize(logger = NULL, taggers = nil, &block)
         def development?; false; end
       end
 
-      class Subscriber < Struct.new(:starts, :finishes)
+      Subscriber = Struct.new(:starts, :finishes) do
         def initialize(starts = [], finishes = [])
           super
         end