- fixing up on the comments raised by on the review

Author: gambol99

node-authorizer/pkg/authorizers/alwaysallow/authorizer.go

@@ -25,19 +25,19 @@ import (
 // alwaysAllowAuth is the implementation for a node authozier
 type alwaysAllowAuth struct{}
 
-// NewAuthorizer creates and returns a aws node authorizer
+// NewAuthorizer creates and returns a alwaysAllow node authorizer
 func NewAuthorizer() (server.Authorizer, error) {
 	return &alwaysAllowAuth{}, nil
 }
 
-// Admit is responsible for accepting the request
+// Authorize is responsible for accepting the request
 func (a *alwaysAllowAuth) Authorize(_ context.Context, req *server.NodeRegistration) error {
 	req.Status.Allowed = true
 
 	return nil
 }
 
-// Name returns the name of of the authozier
+// Name returns the name of the authorizer
 func (a *alwaysAllowAuth) Name() string {
 	return "alwaysAllow"
 }

node-authorizer/pkg/authorizers/aws/authorizer.go

@@ -41,13 +41,13 @@ import (
 
 const (
 	// the default tag used to indicates a kubernetes cluster name
-	kubenetesClusterTag = "KubernetesCluster"
+	kubernetesClusterTag = "KubernetesCluster"
 )
 
 // a collection of aws public signing certificates
 var publicCertificates []*x509.Certificate
 
-// awsNodeAuthorizer is the implementation for a node authozier
+// awsNodeAuthorizer is the implementation for a node authorizer
 type awsNodeAuthorizer struct {
 	// client is the ec2 interface
 	client ec2iface.EC2API
@@ -157,7 +157,7 @@ func (a *awsNodeAuthorizer) validateNodeInstance(ctx context.Context, doc *ec2me
 	}
 
 	// @check the instance is tagged with our kubernetes cluster id
-	if !hasInstanceTags(kubenetesClusterTag, a.config.ClusterName, instance.Tags) {
+	if !hasInstanceTags(kubernetesClusterTag, a.config.ClusterName, instance.Tags) {
 		return "missing cluster tag", nil
 	}
 

node-authorizer/pkg/server/metrics.go

@@ -30,7 +30,7 @@ var (
 	authorizeRequestLatencyMetric = prometheus.NewSummary(
 		prometheus.SummaryOpts{
 			Name: "node_request_latency_seconds",
-			Help: "A summary of the latency for incoming node authoriation requests",
+			Help: "A summary of the latency for incoming node authorization requests",
 		},
 	)
 	authorizerLatencyMetric = prometheus.NewSummary(

node-authorizer/pkg/server/types.go

@@ -115,7 +115,7 @@ type Token struct {
 type NodeRegistrationSpec struct {
 	// NodeName is the name of the node
 	NodeName string
-	// RemoteaAddr is the address of the requester
+	// RemoteAddr is the address of the requester
 	RemoteAddr string
 	// Request is the request body
 	Request []byte
@@ -161,9 +161,6 @@ func (c *Config) IsValid() error {
 	if c.TLSPrivateKeyPath == "" {
 		return errors.New("no private key")
 	}
-	if c.Port <= 0 && c.Port >= 65535 {
-		return errors.New("invalid port")
-	}
 
 	return nil
 }

nodeup/pkg/model/node_authorizer.go

@@ -92,7 +92,7 @@ func (b *NodeAuthorizationBuilder) Build(c *fi.ModelBuilderContext) error {
 	glog.V(3).Infof("bootstrap: %t, node authorization: %t, node authorizer: %t", b.UseBootstrapTokens(),
 		b.UseNodeAuthorization(), b.UseNodeAuthorizer())
 
-	// @check if the NodeAuhtorizer provision the client service for nodes
+	// @check if the NodeAuthorizer provision the client service for nodes
 	if b.UseNodeAuthorizer() && !b.IsMaster {
 		na := b.Cluster.Spec.NodeAuthorization.NodeAuthorizer
 

pkg/model/bootstrapscript.go

@@ -138,7 +138,7 @@ func (b *BootstrapScript) ResourceNodeUp(ig *kops.InstanceGroup, cluster *kops.C
 			}
 			if cs.KubeAPIServer.EnableBootstrapAuthToken != nil {
 				spec["kubeAPIServer"] = map[string]interface{}{
-					"enableBootstrapTokenAuth": cs.KubeAPIServer.EnableBootstrapAuthToken,
+					"enableBootstrapAuthToken": cs.KubeAPIServer.EnableBootstrapAuthToken,
 				}
 			}
 

upup/pkg/fi/cloudup/bootstrapchannelbuilder.go

@@ -113,7 +113,7 @@ func (b *BootstrapChannelBuilder) buildManifest() (*channelsapi.Addons, map[stri
 	// @check if podsecuritypolicies are enabled and if so, push the default kube-system policy
 	if b.cluster.Spec.KubeAPIServer != nil && b.cluster.Spec.KubeAPIServer.HasAdmissionController("PodSecurityPolicy") {
 		key := "podsecuritypolicy.addons.k8s.io"
-		version := "0.0.3"
+		version := "0.0.4"
 
 		{
 			location := key + "/k8s-1.9.yaml"