research stack overflow

Author: nathantippy

core/src/abstract_executor.rs

@@ -63,6 +63,9 @@ pub trait AsyncListener {
     fn local_addr(&self) -> Result<SocketAddr, io::Error>;
 }
 
+
+//TODO: telemetry isprobably broken because Handle is not workng abstracted?
+
 impl AsyncListener for nuclei::Handle<TcpListener> {
     fn accept<'a>(&'a self) -> Pin<Box<dyn Future<Output = Result<(Box<dyn AsyncReadWrite + Send + Unpin + 'static>, Option<SocketAddr>), io::Error>> + Send + 'a>> {
         let fut = self.accept(); // Provided by nuclei::Handle<TcpListener>

core/src/commander_monitor.rs

@@ -1,5 +1,5 @@
 use std::sync::atomic::{AtomicBool, AtomicU64, Ordering};
-use log::{warn};
+use log::{error, warn};
 use std::time::{Duration, Instant};
 use std::sync::Arc;
 use parking_lot::RwLock;
@@ -128,11 +128,21 @@ impl<const RXL: usize, const TXL: usize> LocalMonitor<RXL, TXL> {
 
     //TODO: check usage and add to the SteadyState
     pub(crate) async fn internal_wait_shutdown(&self) -> bool {
+        error!("expecting hang 8");
+
         let one_shot = &self.oneshot_shutdown;
+
         let mut guard = one_shot.lock().await;
+        error!("expecting hang 9");
+
         if !guard.is_terminated() {
+            error!("expecting hang A");
+
             let _ = guard.deref_mut().await;
+            error!("expecting hang B");
+
         }
+        error!("hep inernal shutdwon conffed");
         true
     }
 
@@ -926,10 +936,15 @@ impl<const RX_LEN: usize, const TX_LEN: usize> SteadyCommander for LocalMonitor<
     /// uses opposite boolean as others since we are asking for shutdown
     /// returns true upon shutdown detection
     async fn wait_shutdown(&self) -> bool {
+        error!("expecting hang 5");
+
         let _guard = self.start_profile(CALL_OTHER);
         if self.telemetry.is_dirty() {
+            error!("expecting hang 6.0");
+
             let remaining_micros = self.telemetry_remaining_micros();
-            if remaining_micros <= 0 {
+            if remaining_micros <= 0 && self.is_liveliness_running() {
+                error!("need relay before shutdown?? if so check liveliness");
                 false //need a relay now so return
             } else {
                 let dur = Delay::new(Duration::from_micros(remaining_micros as u64));
@@ -940,6 +955,8 @@ impl<const RX_LEN: usize, const TX_LEN: usize> SteadyCommander for LocalMonitor<
                         }
             }
         } else {
+            error!("expecting hang 6.1");
+
             self.internal_wait_shutdown().await
         }
     }

core/src/graph_liveliness.rs

@@ -208,7 +208,7 @@ impl GraphLiveliness {
                     //Target actor may have already stopped so this is not an error
                 }
             });
-            //trace!("every actor has had one shot shutdown fired now");
+            error!("every actor has had one shot shutdown fired now");
         } else if self.is_in_state(&[GraphLivelinessState::Building]) {
             warn!("request_stop should only be called after start");
         }
@@ -461,7 +461,7 @@ impl GraphBuilder {
         GraphBuilder {
             block_fail_fast: false,
             telemetry_metric_features: false,
-            enable_io_driver: true,
+            enable_io_driver: false,
             backplane: Some(SideChannelHub::default()),
             proactor_config: Some(ProactorConfig::InterruptDriven),
             iouring_queue_length: 1<<5,
@@ -504,6 +504,9 @@ impl GraphBuilder {
     pub fn with_telemetry_metric_features(&self, enable: bool) -> Self {
         let mut result = self.clone();
         result.telemetry_metric_features = enable;
+        if enable {
+            result.enable_io_driver = true;
+        }
         result
     }
 

core/src/monitor.rs

@@ -956,11 +956,15 @@ pub(crate) mod monitor_tests {
         // Simulate shutdown
         {
             let mut liveliness = monitor.runtime_state.write();
+            liveliness.state = GraphLivelinessState::Running;
             liveliness.request_shutdown();
         }
         error!("expecting hang 3");
 
         let result = monitor.wait_shutdown().await;
+
+        error!("expecting hang 4 {}",result);
+
         assert!(result);
     }
 
@@ -1141,6 +1145,7 @@ pub(crate) mod monitor_tests {
     //     // Request shutdown
     //     {
     //         let mut liveliness = monitor.runtime_state.write();
+    //         liveliness.state = GraphLivelinessState::Running;
     //         liveliness.request_shutdown();
     //     }
     //